[mkgmap-dev] one correction of default points style and a suggestion for lines

Fri Dec 3 09:54:43 GMT 2021

Hi.

Havind the emergency=phone separate from amenities sounds good.
For the junction and roundabout, i agree and point taken.

Can send updates later today.

Regards
Karl

2021-12-03 08:53 Gerd Petermann wrote:

> Hi Karl,
>
> interesting, taginfo shows 0 occurences for amenity=emergency_phone: https://taginfo.openstreetmap.org/keys/amenity#values
> I guess this was different when the line was added in 2011. See e.g. https://www.openstreetmap.org/changeset/43747775
> I would not want to place the rule
> emergency=phone [0x2f12 resolution 24 default_name 'Emergency Phone']
> within the block of rules for amenity. Let's simply remove the wrong one and add the new after that block.
>
> reg. roundabout:
> I wonder why you don't want to add the line
> junction=roundabout & highway=service [0x07 road_class=0 road_speed=1 resolution 23]
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von 7770 <7770 at foskan.eu>
> Gesendet: Donnerstag, 2. Dezember 2021 21:31
> An: mkgmap-dev at lists.mkgmap.org.uk
> Betreff: [mkgmap-dev] one correction of default points style and a      suggestion for lines
>
> Hi.
>
> Some time ago i ran into the mistake of tagging emergecy_phone as it is given
> in the default example style  ./mkgmap-r4818/examples/styles/default/points
> on line 148:
> amenity=emergency_phone [0x2f12 resolution 24 default_name 'Emergency Phone']
>
> The correct tagging is however:
> emergency=phone [0x2f12 resolution 24 default_name 'Emergency Phone']
>
> I have therefor updated this and i am attaching a suggested points file.
> I have done the following:
> 1. add a comment on line 148 that the above tagging is incorrect.
> 2. the original line is pushed one line down to 149 and commented out.
> 3. a new line 150 is added with the new tagging.
>
>
> I checked most of Nordic countries and Baltic countries, there were none
> incorrectly tagged emergency phones, i havn't checked the rest of the world,
> but it seems that mistakes should be rare.
>
> If you dont mind and if you feel for it, feel free to add the changes into the
> default example style.
>
>
>
>
> Secondly i have noted  that in the example lines file
> ./mkgmap-r4818/examples/styles/default/lines
> on line 123-143, the section about junction=roundabout, it would be good to
> add the following one line on line 143, and push the current line to 144.
> junction=roundabout & (service=alley | service=driveway) [0x07 road_class=0
> road_speed=1 resolution 23]
>
> The reason for this suggestion is because of line 198 (or 199 after the above
> addition):
> highway=service & (service=alley | service=driveway) [0x07 road_class=0
> road_speed=0 resolution 23]
>
> The combination of these will make sure that roundabouts and highways that are
> marked:  highway=service & (service=alley | service=driveway) and can be
> connected to each other are drawn at the same resolution and with the same
> 0x07 type.
> Otherwise the roundabout is becoming much larger and visible before the
> connecting street/road.
>
> I am attaching an updated lines file as well and again if you dont mind and if
> you feel for it, feel free to add the changes into the default example style.
>
>
> Regards
> Karl
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>