[mkgmap-dev] Fix Sea Patch

Wed Feb 10 08:47:05 GMT 2021

Hi Mike,

if I got that right there is no impact on the PrecompSeaGenerator as that doesn't execute this part of SeaGenerator. There is also no impact on processing when --precomp-sea is used.
However, now the patched code only performs any check when new parameter --check is given. Is that intended? Ticker suggested to add an option for the additional checks.

The doc says that --generate-sea=multipolygon is the default, this is also true with --precomp-sea. Not sure what is confusing you?

I've made some minor changes to the code to reduce complexity, but didn't check the details of the new code.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike at tvage.co.uk>
Gesendet: Montag, 8. Februar 2021 15:58
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Fix Sea Patch

HI Gerd, I don't have a build that includes the PrecompSeaGenerator, but I
would expect the impact to be the same as for in-line sea generation: an
increase in execution time if /check is specified with a reduction if it is
not specified.

I'm not quite clear what happens if you specify --precomp-sea, but don't
specify --generate-sea. The help only says that --precomp-sea can be
combined with --generate-sea but doesn't say what happens if you don't.
(Does it switch on --generate-sea=multipolygon?)

I think the order of the options in the documentation is not ideal either -
I would think --generate-sea should come first, followed by --coastline-file
and that followed by --precomp-sea. Happy to tweak this.

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:gpetermann_muenchen at hotmail.com]
Sent: 07 February 2021 17:36
To: Development list for mkgmap <mkgmap-dev at lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] Fix Sea Patch

Hi Mike and Ticker,

do you expect an impact on the PrecompSeaGenerator?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von
Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Sonntag, 7. Februar 2021 18:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Fix Sea Patch

Hi Mike / Gerd

This patch seems fine to me.

Ticker

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sea5.patch
Type: application/octet-stream
Size: 11958 bytes
Desc: sea5.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20210210/ce5adbb2/attachment-0001.obj>