[mkgmap-dev] patch to improve style throughput

Tue Apr 24 22:06:11 BST 2018

Hi Gerd

I don't think I understand any of this any more :(

It didn't seem right to extract the key from the keystring
so I tried without and the attached patch also passes all
the tests - I make no other claim!

Steve

> Hi Steve,
> 
> I think I found a simple patch to improve the rule index. I've noticed that the unpatched version often returns far more rules to check than expected.
> e.g. if an element has the tag a=3 and we have these 3 rules
> a=1 {...}
> a=2 & b=1 {...}
> a=3 & c=1 {...}
> 
> all three are evaluated, in fact all rules which have a keystring beginning with a= are returned by the index. The patch changes this so that rules which cannot match are not
> returned. This makes style evaluation a bit faster.  I've tried it with a few styles and some input files and found no changes in the output, also all unit tests pass, so I hope I did not miss something.  What do you think?
> 
> Gerd
> 
> 
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tags2.patch
Type: text/x-patch
Size: 1664 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180424/11bef082/attachment.bin>