[mkgmap-dev] Copyright & License file reader improvements

Fri Dec 30 13:37:28 GMT 2016

Hi Gerd, yes I intentionally changed that, as it is illogical to remove
blank lines from a file that has been specifically specified. Especially as
the default message includes blank lines - with blank line removal it is not
possible to create a copy of the standard text from a file. If you have a
license file containing paragraphs of information, you are likely to want to
see the paragraphs separated, rather than merged into an amorphous block. I
forgot to mention this when posting the patch.

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:GPetermann_muenchen at hotmail.com] 
Sent: 29 December 2016 13:40
To: Development list for mkgmap <mkgmap-dev at lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Mike,

if I got that right the original code ignores empty lines in the licence
file, the patch doesn't.
Is that intended?
I have no idea what's better, so I'll wait for a comment from Steve.

Gerd
________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike
Baggaley <mike at tvage.co.uk>
Gesendet: Donnerstag, 29. Dezember 2016 12:53:15
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Gerd, please find an updated patch for improvements to the copyright
reader. As discussed, this updates the documentation to say that the files
must be UTF-8 encoded, and improves the error message to give the cause of
the failure if the copyright or license file cannot be read.

The code for reading style files does not appear to specify UTF-8.

Please try and commit if happy.

Thanks,
Mike