[mkgmap-dev] Patch v1: check if road is connected

Sat Mar 9 12:05:35 GMT 2013

Hi Chris,

thanks for testing.
In fact I forgot to remove the printout to stdout. I think they should only
be written with the logger and I don't think that they are errors, but
infos. 
Reg. the "false" positives: Sounds like it works as expected, a routable way
that is only connected to non-routable ways is itself not routable. Or do
you think this should not be done? 

Gerd

Chris66 wrote
> Am 04.03.2013 10:15, schrieb GerdP:
> 
>> attached is a patch that implements the check discussed here:
>> 
>> http://gis.19327.n5.nabble.com/Style-function-is-connected-tp5750777.html
>> 
>> check_connected_v1.patch
>> &lt;http://gis.19327.n5.nabble.com/file/n5751822/check_connected_v1.patch&gt;  
>> 
>> If a way is a road and has has the mkgmap:check_connected=true tag mkgmap
>> does a check if this road is connected to any other road. If not, the way 
>> is not added to the road network.
>> 
>> Sample change in style file lines:
>> highway=service {add mkgmap:check_connected = true}[0x07 road_class=0
>> road_speed=2 resolution 22]  
>> 
>> I am not sure if this gives the wanted result, so please try and let me
>> know.
> 
> Hi,
> 
> all in all this works as designed.
> 
> Some remarks:
> 
> Could you write the messages to stderr and not stdout?
> 
> Some examples reported as unconnected roads (There are a lot):
> 
> http://www.openstreetmap.org/browse/way/203926670
> http://www.openstreetmap.org/browse/way/125088993
> http://www.openstreetmap.org/browse/way/134036540 (false positive?)
> http://www.openstreetmap.org/browse/way/98294931  (false positive?)
> http://www.openstreetmap.org/browse/way/138226874 (false positive?)
> http://www.openstreetmap.org/browse/way/174042755
> http://www.openstreetmap.org/browse/way/204836534
> http://www.openstreetmap.org/browse/way/139074879
> http://www.openstreetmap.org/browse/way/84190202
> http://www.openstreetmap.org/browse/way/138274835
> http://www.openstreetmap.org/browse/way/42075818
> http://www.openstreetmap.org/browse/way/188368806
> http://www.openstreetmap.org/browse/way/117567530
> http://www.openstreetmap.org/browse/way/135256258
> http://www.openstreetmap.org/browse/way/85255168
> http://www.openstreetmap.org/browse/way/58654113
> http://www.openstreetmap.org/browse/way/195174736
> 
> (note that footways are not routable in my style).
> 
> Some false positives may result from the "remove inaccessible tunnels"
> style code.
> 
> Performance : I see no performance drop
> 
> Chris
> 
> 
> 
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/Patch-v1-check-if-road-is-connected-tp5751822p5752525.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.