[mkgmap-dev] [PATCH v1] add-pois-to-lines

Sun Oct 30 13:27:39 GMT 2011

Moin,

WanMil schrieb am 30.10.2011 14:10:
> The relation style is applied after the pois-to-lines. Maybe this could 
> be changed but I don't know about side effects.

That is bad news, because using the add-pois-to-line options for marking hiking
routes is one of the uses I had in mind.

> It is either possible to create completely new nodes (this is 
> implemented) or to add the tags from the line to the existing nodes 
> (then you get a "merge" problem if both line and node contains the same 
> tag with different values). I decided to implement the first solution 
> which is much easier.

Ah. That's the better solution and should also solve my issue No.4, where a
single node is member in multiple lines.
So you will have multiple nodes on the same coordinates:
- 1 node with all the original tags from this node
- 1 node for each line, with the tags mkgmap:line2poi=true,
mkgmap:line2poitype=* and all the tags from this line

> You report that the information of original node is lost. I don't think 
> so.

I can confirm, that the information from the original node is not lost. I
feared, that in case of a conflict the information from the line would get lost.
But know I understand your implementation better.

So beside the relation topic I am happy with your patch, even with this
limitation I think it is worthwhile extension of the mkgmap possibilities. Thanks.

Gruss
Torsten