[mkgmap-dev] special case where splitting fails without a log message

Wed Jun 2 12:36:02 BST 2021

Hi Gerd

I was beginning to suspect this - there were 2 very close cut-lines
which is why I thought coords were not behaving.

I've reproduced with the .osm and am investigating 

Ticker

On Wed, 2021-06-02 at 09:50 +0000, Gerd Petermann wrote:
> Hi Ticker,
> 
> yes, was with splitShapeFix_5_lowRes.patch
> I've just noticed that s_3 and s_4 were from a different split.
> The shape was the result of various steps with "too small island
> removal" and "cut again after full merge".
> 
> Maybe you can reproduce with the attached file. I've loaded the gpx
> into JOSM, fixed the duplicated points and used Shift+J (join
> overlapping areas)
> 
> Gerd
> 
> 
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Mittwoch, 2. Juni 2021 11:23
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] special case where splitting fails without
> a log message
> 
> Hi Gerd
> 
> I see what you mean. Is this with splitShaeFix_5_lowRes.patch?
> I'll investigate. Is there an OSM file I can run with?
> 
> Ticker
> 
> On Wed, 2021-06-02 at 06:32 +0000, Gerd Petermann wrote:
> > Hi Ticker,
> > 
> > please check 
> > https://files.mkgmap.org.uk/download/509/special-v5.zip
> > 
> > Can you tell me why ShapeSplitter drops some points, e.g the one
> > near
> > 68.2669706, 15.1206053 without complaining?
> > None of the points in the original data is visited more than twice
> > and all highprec equal points are unique.
> > 
> > I'm working on an improvement to make the connecting lines shorter,
> > but I don't see yet how I can avoid to have connecting lines like
> > that.
> > 
> > Gerd
> > 
> > ________________________________________
> > Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> > von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> > Gesendet: Dienstag, 1. Juni 2021 17:18
> > An: Development list for mkgmap
> > Betreff: Re: [mkgmap-dev] special case where splitting fails
> > without
> > a log message
> > 
> > Hi Gerd
> > 
> > I've added code to deal with some variants of the case as described
> > -
> > I
> > hope this will be enough to cope with more complex shapes generated
> > by
> > ShapeMerger.
> > 
> > There might be a bit more I can do without having to resort to more
> > complex geometry analysis if it still gives problems.
> > 
> > I've also restructured it a bit.
> > 
> > Patch attached based on low-res-opt. Trunk version will be the same
> > (but the patch would be different)
> > 
> > Ticker
> > 
> > On Mon, 2021-05-31 at 17:12 +0100, Ticker Berkin wrote:
> > > Hi Gerd
> > > 
> > > shapeSplitter will have problems (ie get it wrong some of the
> > > time)
> > > where there are in/out lines to a hole that share the same cut
> > > point
> > > as
> > > a line that is the boundary between a shape and hole; could be
> > > many
> > > holes (or shapes) and many lines. The simple sort/dedupe I was
> > > doing
> > > isn't adequate. I'll come up with something better tomorrow.
> > > 
> > > Ticker
> > > 
> > > _______________________________________________
> > > mkgmap-dev mailing list
> > > mkgmap-dev at lists.mkgmap.org.uk
> > > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev