logo separator

[mkgmap-dev] patch to improve style throughput

From Gerd Petermann gpetermann_muenchen at hotmail.com on Sat Apr 28 08:34:36 BST 2018

Hi Steve,

after committing the tags3.patch with r4182 yesterday I wondered why I did not find a unit test which shows the problem that I fixed with r3822:

I've now added that test to make sure that the new code works. It does :)
I got curious and tried RuleIndex.java from r3820 and was surprised to find that it alse passes all tests.

In the end the code in RuleIndex was okay, the error was in the code that arranged expressions and you fixed that recently.
The good thing is that the old code was even better than that in tags3.patch, so I've created a new patch which is basically
a revert of the changes in r3822  and r4182.

Please review and try to find a unit test that would not work with that patch.


Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve at parabola.me.uk>
Gesendet: Donnerstag, 26. April 2018 23:33:53
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch to improve style throughput

Hi Gerd

> here is the improved version of the patch. It reduces the number of rules to be checked a bit more.

Thanks, that seems to work well.

mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tags4.patch
Type: application/octet-stream
Size: 5107 bytes
Desc: tags4.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180428/0fd8e9ed/attachment.obj>

More information about the mkgmap-dev mailing list