[mkgmap-dev] mkgmap4176 java-error

Wed Apr 25 18:44:14 BST 2018

Hi Gerd

Yes, but in "buildFromCountries()" above, near index.add(mdr29), or as
a pre-scan in writeSectData before setting size17 = numberToPointerSize

Ticker

On Wed, 2018-04-25 at 17:26 +0000, Gerd Petermann wrote:
> Hi Ticker,
> 
> thanks for the hint. I agree that the code to set max17 looks
> suspicious.
> Can't test right now, I think we just have to change
> this.max17 = r.getMdr17();
> to
> this.max17 = Math.max(this.max17, r.getMdr17());
> 
> Do you agree?
> Gerd
> 
> 
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Mittwoch, 25. April 2018 19:06:18
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] mkgmap4176 java-error
> 
> Hi Gerd
> 
> I've been have a look at this as well.
> 
> The pre-io-change version of putNu didn't check that the value could
> be
> expressed in the given nBytes, so this error could have existed for a
> while
> 
> The logic in MDR29 just picks the last record in
>         private final List<Mdr29Record> index = new ArrayList<>();
> assumes that getMdr17() from this has the highest value and can be
> used
> to determine nBytes for all the records in the call to
>    writer.putNu(size17, record.getMdr17());
> Ticker
> 
> On Wed, 2018-04-25 at 18:26 +0200, Arndt Röhrig wrote:
> > Hi Gerd,
> > here are the complete error-message:
> > Exception in thread "main" java.lang.AssertionError: 16735
> > at
> > uk.me.parabola.imgfmt.app.FileBackedImgFileWriter.putNu(FileBackedI
> > mg
> > FileWriter.java:213)
> > at uk.me.parabola.imgfmt.app.mdr.Mdr29.writeSectData(Mdr29.java:96)
> > at
> > uk.me.parabola.imgfmt.app.mdr.MDRFile.writeSection(MDRFile.java:421
> > )
> > at
> > uk.me.parabola.imgfmt.app.mdr.MDRFile.writeSections(MDRFile.java:38
> > 5)
> > at uk.me.parabola.imgfmt.app.mdr.MDRFile.write(MDRFile.java:269)
> > at
> > uk.me.parabola.mkgmap.combiners.MdrBuilder.onFinishForDevice(MdrBui
> > ld
> > er.java:355)
> > at
> > uk.me.parabola.mkgmap.combiners.GmapsuppBuilder.onFinish(GmapsuppBu
> > il
> > der.java:178)
> > at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:678)
> > at
> > uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReader.
> > ja
> > va:128)
> > at uk.me.parabola.mkgmap.main.Main.mainStart(Main.java:143)
> > at uk.me.parabola.mkgmap.main.Main.main(Main.java:114)
> > 
> > Greets
> > Arndt
> > > Gerd Petermann hat am 25. April 2018 um 17:13 geschrieben:
> > > 
> > > 
> > > Hi Arndt,
> > > 
> > > this one is not so obvious to me. Please can you post the
> > > complete
> > > error message, esp. the line with
> > > AssertionError ?
> > > 
> > > Gerd
> > > 
> > > ________________________________________
> > > Von: mkgmap-dev im Auftrag von Arndt Röhrig
> > > Gesendet: Mittwoch, 25. April 2018 15:27:30
> > > An: Development list for mkgmap
> > > Betreff: [mkgmap-dev] mkgmap4176 java-error
> > > 
> > > Hi @all
> > > 
> > > mkgmap4176 failed to build a map from Bayern. (aftes building all
> > > tiles) 4165 works well.
> > > 
> > > Maybe a similar problem like yesterday?
> > > 
> > > Or some exotic types in my style?
> > > 
> > > FileWriter.java:213)
> > > at
> > > uk.me.parabola.imgfmt.app.mdr.Mdr29.writeSectData(Mdr29.java:96)
> > > at
> > > uk.me.parabola.imgfmt.app.mdr.MDRFile.writeSection(MDRFile.java:4
> > > 21
> > > )
> > > at
> > > uk.me.parabola.imgfmt.app.mdr.MDRFile.writeSections(MDRFile.java:
> > > 38
> > > 5)
> > > 
> > > at uk.me.parabola.imgfmt.app.mdr.MDRFile.write(MDRFile.java:269)
> > > at
> > > uk.me.parabola.mkgmap.combiners.MdrBuilder.onFinishForDevice(MdrB
> > > ui
> > > ld
> > > er.java:355)
> > > at
> > > uk.me.parabola.mkgmap.combiners.GmapsuppBuilder.onFinish(Gmapsupp
> > > Bu
> > > il
> > > der.java:178)
> > > at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:678)
> > > at
> > > uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReade
> > > r.
> > > ja
> > > va:128)
> > > at uk.me.parabola.mkgmap.main.Main.mainStart(Main.java:143)
> > > at uk.me.parabola.mkgmap.main.Main.main(Main.java:114)
> > > 
> > > 
> > > Greetz
> > > 
> > > Arndt
> > > _______________________________________________
> > > mkgmap-dev mailing list
> > > mkgmap-dev at lists.mkgmap.org.uk
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev