[mkgmap-dev] area_size() function to be used in points file

Thu Apr 19 12:09:45 BST 2018

Hi Ticker,

thanks for the quick patch.
I don't know if a height or widht value of 0 is OK or not.
If it is I see no reason for a warning, if not it should be handled somewhere else.

@Steve: Do you know more?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Donnerstag, 19. April 2018 12:46:43
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] area_size() function to be used in points file

I was being a bit too severe. Zero and negative width/height
subdivisions previously were allowed through without being noticed,
with the negative quietly overflowing looking positive.

The attached patch downgrades the message for zero size to a warning
but flags an error for neg.

Regards
Ticker

On Thu, 2018-04-19 at 09:49 +0000, Gerd Petermann wrote:
> Hi Joris,
>
> thanks for testing. The severe messages were introduced with the
> latest patches from Ticker:
> http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4167
>
> The added source in Subdivision.java:
>                 if (w <= 0) { // think can get this from
> empty/unbounded maps
>                         log.error("Subdivision neg width ", w,
> "min=", area.getMinLong(), "mid=", longitude, "max=",
> area.getMaxLong(), "shift=", shift, "mask=", mask, "@", getCenter());
>                         w = 0x7fff;
>                 }
>
> @Ticker:
> I don't know why we have those new messages?
>
> Gerd