[mkgmap-dev] [Patch v1] remove obsolete spaces from tag values

Wed Oct 14 09:43:24 BST 2015

Hi all,

attached is v1 of the patch for the issue discussed here:
http://gis.19327.n5.nabble.com/obsolete-spaces-in-tags-tt5856850.html

It implements option a) :
Remove spaces before style processing.
If I here no complains I'll commit this next Monday.

Remarks:
1) Unfortunately it doesn't really improve address search in Canada.
In my test case some more addresses are found, but a lot of 
"found no plausible road " messages remained.
Reasons:
1) Abbreviations used in names, e.g. 
"Av Jackson" vs "Avenue Jackson", 
"Pl Gabriel" vs  "Place Gabriel", etc.
Some of them might be fixed using appropriate style rules,
see attached patch canada_addr_v1.patch
2) Other spelling differences, e.g. 
"Rue Mozart" vs "Rue de Mozart"
"Boulevard Saint-Laurent" vs "Rue  Saint-Laurent"

2) Since r2906 obsolete spaces in the values of tags mkgmap:label:1..4 are removed
(after style processing). This was added with the mergeroads code. 
@WanMil: Maybe this code in StyledConverter.elementSetup()  is obsolete with the 
new patch? 

For those that like to test it:
see 
http://files.mkgmap.org.uk/download/284/mkgmap.jar
and my test case:
http://files.mkgmap.org.uk/download/283/double_spaces.osm

Ciao,
Gerd

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20151014/babeeb55/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: squash_spaces_v1.patch
Type: application/octet-stream
Size: 7852 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20151014/babeeb55/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: canada_addr_v1.patch
Type: application/octet-stream
Size: 805 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20151014/babeeb55/attachment-0001.obj>