[mkgmap-dev] [PATCH v3] Multipolygon: Improved role handling

Thu Mar 18 17:10:13 GMT 2010

> 2010/03/18 09:08:55 WARNING (MultiPolygonRelation): 63240004.osm.gz: Multipolygon http://www.openstreetmap.org/browse/relation/301046 contains errors.
> 2010/03/18 09:08:55 WARNING (MultiPolygonRelation): 63240004.osm.gz: Polygon 4611686018427484412(7P : (43036113[6P]) carries role inner but is not inside any other polygon. Potentially it does not belong to this multipolygon.
> 2010/03/18 09:08:55 WARNING (MultiPolygonRelation): 63240004.osm.gz: Polygon 4611686018427484414(8P : (43036115[7P]) carries role inner but is not inside any other polygon. Potentially it does not belong to this multipolygon.
>
> Geofabrik problem.
>
> Do you agree with my guess that these generated IDs must be coming from the
> multipolygons quoted immediately above them?

Yes that's true. A warning always consists of one line with the mp link 
and the further lines print out the specific warnings for this mp.

>
> Then, finally we have a mystery multipolygon where your patch did not
> seem to help to identify the source:

The mystery mp is generated by the generate-sea code and is the final 
sea multipolygon.

>
> 2010/03/18 09:09:08 WARNING (MultiPolygonRelation): 63240004.osm.gz: Multipolygon http://www.openstreetmap.org/browse/relation/4611686018427488909 contains errors.
> 2010/03/18 09:09:08 WARNING (MultiPolygonRelation): 63240004.osm.gz: Polygon 4611686018427489620(65P : (4614558[65P]) carries role inner but lies inside an inner polygon. Potentially its role should be outer.
> 2010/03/18 09:09:08 WARNING (MultiPolygonRelation): 63240004.osm.gz: Polygon 4611686018427489967(18P : (42942687[18P]) carries role inner but lies inside an inner polygon. Potentially its role should be outer.
> 2010/03/18 09:09:08 WARNING (MultiPolygonRelation): 63240004.osm.gz: Polygon 4611686018427489992(28P : (52019072[28P]) carries role inner but lies inside an inner polygon. Potentially its role should be outer.
>
> This would be in Northern Finland, most likely on the north tip of the Baltic sea,
> near the Swedish border.  Let us see if my guess was right:
>
> http://www.openstreetmap.org/browse/way/4614558
> http://www.openstreetmap.org/browse/way/42942687
> http://www.openstreetmap.org/browse/way/52019072
>
> Right, all the objects are near Tornio/Haparanda, near the Finnish/Swedish
> border.  I fixed it in JOSM.  It seems that the natural=coastline has
> recently been changed to waterway=riverbank, but some islands were forgotten
> as natural=coastline, and one island was a duplicate polygon.  One island
> is natural=coastline bordered by waterway=riverbank and natural=coastline.
> I will move the waterway=riverbank a little further to the coast, just around
> the island.
>
> Thanks for your help!
>
> 	Marko

So we have to wait til tomorrow and then you can check if the 
generate-sea code will generate a full valid sea area without any 
flodding for finland? Wow, I hope that's working!

WanMil