[mkgmap-dev] generate-sea option and faster-mp changes

Thu May 12 07:20:27 BST 2022

Hi Gerd

I've just rebuilt britain-and-ireland-latest.osm.pbf with the current
trunk and find that many tiles on the coast have flooded rectangles.
The coastline is all correct and these flooded area are normally well
inland and unrelated to where the coastline crosses the tile boundary.

I use option
  --generate-sea="multipolygon,extend-sea-sectors,close-gaps=750"
and this worked fine up to about a year ago - I've only just noticed
the problem.

Cutting this from a suitable area (Wales, UK, Britain, Europe etc)

74220030: 2408448,-331776 to 2430976,-196608
#       : 51.679688,-7.119141 to 52.163086,-4.218750

and building with minimal options plus above and default style should
demonstrate the problem. There are also extra error messages starting

... 030.osm.pbf: Multipolygon generated SeaPolygonRelation [nat...

in the log file, which I attach

I think it is related to the faster-mp changes and the MP structure
SeaGenerator created. This has 1 outer (the tile) and all bits of land
are inners, including land touching the edge of the tile.

I've attached a patch for an enhanced version of SeaGenerator that
distinguishes between land/sea areas that touch the edge and true
[anti-]islands and only use MP processing for the islands. With this,
tiles are correct.

It also has other benefits: It is clearer in what is happening, doesn't
do a lot of pointless tagging of ways that will joined to become
polygons, etc

Ticker

-------------- next part --------------
FINE: uk.me.parabola.mkgmap.main.Main  option: number-of-files 1
FINE: uk.me.parabola.mkgmap.main.Main  option: mapname 63240001
FINE: uk.me.parabola.mkgmap.main.Main  option: description OSM street map
FINE: uk.me.parabola.mkgmap.main.Main  option: overview-mapname osmmap
FINE: uk.me.parabola.mkgmap.main.Main  option: overview-mapnumber 63240000
FINE: uk.me.parabola.mkgmap.main.Main  option: poi-address 
FINE: uk.me.parabola.mkgmap.main.Main  option: merge-lines 
FINE: uk.me.parabola.mkgmap.main.Main  option: area-name fldfA
FINE: uk.me.parabola.mkgmap.main.Main  option: code-page 1252
FINE: uk.me.parabola.mkgmap.main.Main  option: drive-on left
FINE: uk.me.parabola.mkgmap.main.Main  option: family-id 7420
FINE: uk.me.parabola.mkgmap.main.Main  option: family-name fldfF
FINE: uk.me.parabola.mkgmap.main.Main  option: generate-sea multipolygon
FINE: uk.me.parabola.mkgmap.main.Main  option: mapset-name fldfM
FINE: uk.me.parabola.mkgmap.main.Main  option: overview-mapnumber 74200000
FINE: uk.me.parabola.mkgmap.main.Main  option: preserve-element-order 
FINE: uk.me.parabola.mkgmap.main.Main  option: region-abbr ABBR
FINE: uk.me.parabola.mkgmap.main.Main  option: region-name fldfR
FINE: uk.me.parabola.mkgmap.main.Main  option: series-name fldfS
FINE: uk.me.parabola.mkgmap.main.Main  option: mapname 74200001
FINE: uk.me.parabola.mkgmap.main.Main  option: description fldfD
FINE: uk.me.parabola.mkgmap.main.Main  file ../mapGB/74220030.osm.pbf , extension is pbf
INFO: uk.me.parabola.mkgmap.main.Main  Submitting job ../mapGB/74220030.osm.pbf
FINE: uk.me.parabola.mkgmap.main.Main  option: description fldfG
OVER: global  Mkgmap version none
OVER: global  Time started: Thu May 12 06:40:41 BST 2022
INFO: uk.me.parabola.mkgmap.main.Main  Start tile processors
INFO: uk.me.parabola.mkgmap.main.Main  Creating thread pool with 1 threads
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Node with unknown role is ignored outer http://www.openstreetmap.org/node/6406767339 in multipolygon http://www.openstreetmap.org/relation/9487722 [area=yes, name=Plas Treforgan Holiday Cottages, phone=+44 1239 615430, tourism=accommodation, type=multipolygon]
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Node with unknown role is ignored outer http://www.openstreetmap.org/node/6406767340 in multipolygon http://www.openstreetmap.org/relation/9487722 [area=yes, name=Plas Treforgan Holiday Cottages, phone=+44 1239 615430, tourism=accommodation, type=multipolygon]
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/10002574 [natural=wood, type=multipolygon] contains errors.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Polygon 4611686018427510963(17P)(722168720[17P]) carries role inner but lies inside an inner polygon. Potentially its role should be outer.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/10109409 does not contain any way tagged with role=outer or empty role.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/11046992 does not contain any way tagged with role=outer or empty role.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Way role invalid in` http://www.openstreetmap.org/way/825925725 in multipolygon http://www.openstreetmap.org/relation/11299713 [natural=water, type=multipolygon, water=pond]
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/11579011 [leisure=garden, name=Colby Woodland Garden, natural=wood, type=multipolygon] contains errors.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Polygon 4611686018427526677(6P)(262068191[6P]) carries role inner but lies inside an inner polygon. Potentially its role should be outer.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/13048971 does not contain any way tagged with role=outer or empty role.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/13049762 does not contain any way tagged with role=outer or empty role.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon http://www.openstreetmap.org/relation/13061091 does not contain any way tagged with role=outer or empty role.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Non Way/Node member with role is ignored subarea http://www.openstreetmap.org/relation/62273 in multipolygon http://www.openstreetmap.org/relation/13428950 [boundary=historic, description=Ireland, name=Éire / Ireland, type=boundary]
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon generated SeaPolygonRelation [natural=sea, type=mkgmap:seapolygon] contains errors.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Polygon 4611686018427565187(5P)(4611686018427560562[45194P]) carries role inner but is not inside any other polygon. Potentially it does not belong to this multipolygon.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Way 4611686018427560562 is composed of other artificial ways. Details:
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Start: http://www.openstreetmap.org/?mlat=51.679688&mlon=-4.924210&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Mid:   http://www.openstreetmap.org/?mlat=51.899056&mlon=-5.296845&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon generated SeaPolygonRelation [natural=sea, type=mkgmap:seapolygon] contains errors.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Polygon 4611686018427565260(5P)(4611686018427560562[45194P]) carries role inner but is not inside any other polygon. Potentially it does not belong to this multipolygon.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Way 4611686018427560562 is composed of other artificial ways. Details:
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Start: http://www.openstreetmap.org/?mlat=51.679688&mlon=-4.924210&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Mid:   http://www.openstreetmap.org/?mlat=51.899056&mlon=-5.296845&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon generated SeaPolygonRelation [natural=sea, type=mkgmap:seapolygon] contains errors.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Polygon 4611686018427565596(5P)(4611686018427560562[45194P]) carries role inner but is not inside any other polygon. Potentially it does not belong to this multipolygon.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Way 4611686018427560562 is composed of other artificial ways. Details:
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Start: http://www.openstreetmap.org/?mlat=51.679688&mlon=-4.924210&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Mid:   http://www.openstreetmap.org/?mlat=51.899056&mlon=-5.296845&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Multipolygon generated SeaPolygonRelation [natural=sea, type=mkgmap:seapolygon] contains errors.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Polygon 4611686018427565688(5P)(4611686018427560562[45194P]) carries role inner but is not inside any other polygon. Potentially it does not belong to this multipolygon.
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf: Way 4611686018427560562 is composed of other artificial ways. Details:
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Start: http://www.openstreetmap.org/?mlat=51.679688&mlon=-4.924210&zoom=17
WARN: uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation  ../mapGB/74220030.osm.pbf:  Mid:   http://www.openstreetmap.org/?mlat=51.899056&mlon=-5.296845&zoom=17
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=51.991960&mlon=-4.980285&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=51.991960&mlon=-4.980285&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=51.991960&mlon=-4.980285&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=51.991960&mlon=-4.980285&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=51.991960&mlon=-4.980285&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=52.061748&mlon=-4.607507&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=52.061748&mlon=-4.607507&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: ignoring duplicate shape with id 4611686018427515572 at http://www.openstreetmap.org/?mlat=52.036185&mlon=-4.470695&zoom=17 with type 0x13 for resolution 24
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: ignoring duplicate shape with id 0 at http://www.openstreetmap.org/?mlat=52.116036&mlon=-4.505916&zoom=17 with type 0x13 for resolution 24
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: ignoring duplicate shape with id 4611686018427511457 at http://www.openstreetmap.org/?mlat=52.074961&mlon=-4.263041&zoom=17 with type 0x13 for resolution 24
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=52.074944&mlon=-4.263001&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: ignoring duplicate shape with id 4611686018427511456 at http://www.openstreetmap.org/?mlat=52.074857&mlon=-4.262968&zoom=17 with type 0x13 for resolution 24
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=52.074771&mlon=-4.263044&zoom=17 (maybe overlapping shapes?)
WARN: uk.me.parabola.mkgmap.filters.ShapeMergeFilter  ../mapGB/74220030.osm.pbf: merging shapes skipped for shapes near http://www.openstreetmap.org/?mlat=52.074771&mlon=-4.263044&zoom=17 (maybe overlapping shapes?)
FINE: uk.me.parabola.mkgmap.main.Main  ../mapGB/74220030.osm.pbf: adding output name /norbert/tstMisc/./74200001.img
OVER: global  Number of MapFailedExceptions: 0
INFO: uk.me.parabola.mkgmap.main.Main  Combining maps
INFO: uk.me.parabola.mkgmap.main.Main    /norbert/tstMisc/./ovm_74200001.img
INFO: uk.me.parabola.mkgmap.main.Main    ../mapGB/74220030.osm.pbf -> /norbert/tstMisc/./74200001.img
OVER: global  Number of ExitExceptions: 0
OVER: global  Time finished: Thu May 12 06:41:24 BST 2022
OVER: global  Total time taken: 43 seconds
-------------- next part --------------
A non-text attachment was scrubbed...
Name: genSeaEnhance_v3.patch
Type: text/x-patch
Size: 18785 bytes
Desc: not available
URL: <https://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20220512/2f8ccc3b/attachment-0001.bin>