[mkgmap-dev] Commit r4845: merge from faster-mp branch

Thu Jan 6 16:54:16 GMT 2022

Hi all,

the problem is (again) caused by an imcomplete monster MP with natural=bay https://www.openstreetmap.org/relation/7075622
and the unability of mkgmap to close the outer ring correctly so that it contains the tile.

The old code also didn't work well in this case but did not complain, it simply closed the outer straight
through the tile boundary and also through the inner ring.

@Arndt: If I got that right you use osmconvert with a poly file to create the input for splitter. This may be the reason for
the incomplete data as you don't tell osmconvert to keep data complete. No idea how much longer it will take if you
add the corresponding parameters.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen at hotmail.com>
Gesendet: Donnerstag, 6. Januar 2022 16:24
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Commit r4845: merge from faster-mp branch

Hi Arndt,

OK, I can reproduce the problem.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Arndt Röhrig <arndt at speichenkarte.de>
Gesendet: Donnerstag, 6. Januar 2022 16:04
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Commit r4845: merge from faster-mp branch

He Gerd,

ok, thanks for the hint. This file makes the trouble, but only with speichenstyle, default style works:

https://speichenkarte.de/79190003.osm.pbf

I have no idea, what line in the style is wrong.

Greetzs

Arndt

Gerd Petermann <gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>> hat am 06.01.2022 15:32 geschrieben:

Hi Arndt,

first make sure that you can reproduce the problem with those tiles and your style.
There is not much that can be wrong in the style, this error happens while reading the input file.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>> im Auftrag von Arndt Röhrig <arndt at speichenkarte.de<mailto:arndt at speichenkarte.de>>
Gesendet: Donnerstag, 6. Januar 2022 15:26
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Commit r4845: merge from faster-mp branch

Hi Gerd,

the default style works.i try to find out, what is wrong in the style.

Greetz

Arndt

Greetz

Arndt
Gerd Petermann <gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>>> hat am 06.01.2022 15:08 geschrieben:

Hi Arndt,

cannot yet reproduce this. Does it also happen with the default style?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>>> im Auftrag von Arndt Röhrig <arndt at speichenkarte.de<mailto:arndt at speichenkarte.de><mailto:arndt at speichenkarte.de<mailto:arndt at speichenkarte.de>>>
Gesendet: Donnerstag, 6. Januar 2022 14:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Commit r4845: merge from faster-mp branch

Hi Gerd,

https://speichenkarte.de/79190004.osm.pbf
from Balearen or
https://speichenkarte.de/79210147.osm.pbf
from the alps.

Greetz

Arndt

Gerd Petermann <gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>>>> hat am 06.01.2022 14:53 geschrieben:

Hi Arndt, please post a link to the problematic pbf file.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>>>> im Auftrag von Arndt Röhrig <arndt at speichenkarte.de<mailto:arndt at speichenkarte.de><mailto:arndt at speichenkarte.de<mailto:arndt at speichenkarte.de>><mailto:arndt at speichenkarte.de<mailto:arndt at speichenkarte.de><mailto:arndt at speichenkarte.de<mailto:arndt at speichenkarte.de>>>>
Gesendet: Donnerstag, 6. Januar 2022 14:49
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Commit r4845: merge from faster-mp branch

Hi Gerd,

the balearic islands cause trouble. Maybe its a wrong split from osmconvert (eurpe->iberia->balearen), but r-4839 works weill.

13:43:23,46 - splitter Speiche_Balearen
Warning: --keep-complete is only used for the first input file. Further files must use higher ids.
13:44:06,30 - mkgmap .\tools\mkgmap-r4845 Speiche_Balearen
Exception in thread "main" java.lang.AssertionError: no outer way in partition
at uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation.processPartition(MultiPolygonRelation.java:705)
at uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation.processElements(MultiPolygonRelation.java:622)
at uk.me.parabola.mkgmap.reader.osm.ElementSaver.addRelation(ElementSaver.java:163)
at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinHandler$BinParser.parseRelations(OsmBinHandler.java:215)
at crosby.binary.BinaryParser.parse(Unknown Source)
at crosby.binary.BinaryParser.handleBlock(Unknown Source)
at crosby.binary.file.FileBlock.process(Unknown Source)
at crosby.binary.file.BlockInputStream.process(Unknown Source)
at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinHandler.parse(OsmBinHandler.java:54)
at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.parse(OsmMapDataSource.java:167)
at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:142)
at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:165)
at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:58)
at uk.me.parabola.mkgmap.main.Main.lambda$processFilename$1(Main.java:291)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)

Greetz

Arndt
Gerd Petermann <gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>>><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com><mailto:gpetermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>>>>> hat am 05.01.2022 11:19 geschrieben:

Hi all,

I've finally found the courage to merge the faster-mp branch into trunk.
I think the change in the default style was always meant to be done in trunk, not in that branch only.

Funny thing is that the original problematic monster MP that triggered this branch was deleted:
https://www.openstreetmap.org/relation/9488835

Those who analyse log messages from class MultiPolygonRelation may find different
results using this new version (sometimes more, sometiles fewer).
Let me know if this causes trouble.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>>>>> im Auftrag von svn commit <svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk>><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk>>><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk>><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk><mailto:svn at mkgmap.org.uk<mailto:svn at mkgmap.org.uk>>>>>
Gesendet: Mittwoch, 5. Januar 2022 11:11
An: mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk>><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk>>><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk>><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk><mailto:mkgmap-svn at lists.mkgmap.org.uk<mailto:mkgmap-svn at lists.mkgmap.org.uk>>>>; mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>>>
Betreff: [mkgmap-dev] Commit r4845: merge from faster-mp branch

Version mkgmap-r4845 was committed by gerd on Wed, 05 Jan 2022

merge from faster-mp branch
- don't render natural=coastline in lines
- implement faster (but possibly less reliable) algorithm to render complex multipolygons
- don't render MP without tags (old code did that when all tags were removed because they did not appear in style rules, see field tagsIncomplete)

http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4845
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>>>
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>>>
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>>
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>>
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev