[mkgmap-dev] New assertion, now with code-page=632 and Japan tile

Tue Nov 9 20:55:08 GMT 2021

Hi

I think this assertion could be removed from the code.

Looking through the definition of Shift-JIS, I read it as saying the 
second byte shouldn't be zero, so I don't know why this happens.

As with the Chinese code-pages, mkgmap has places where multi-byte 
encodings are not handled correctly in the --index generation and 
unknown meanings of flags to the Garmin software.

Ticker

On 09/11/2021 19:43, Carlos Dávila wrote:
> code-page=932, sorry for the typo.
> 
> El 9/11/21 a las 20:36, Carlos Dávila escribió:
>> The command below produces an assertion while compiling this tile 
>> <https://files.mkgmap.org.uk/download/526/31191025.o5m> from Japan. 
>> Process continues with remaining tiles and finishes without "Number of 
>> MapFailedExceptions: 1" as expected. This is with r4813, but I also 
>> tried with an old version of mkgmap with the same result.
>>
>> java -Xmx27G -ea -jar mkgmap.jar--code-page=632 31191025.o5m
>> Mkgmap version 4813
>> Time started: Tue Nov 09 20:18:16 CET 2021
>> WARNING (global): Setting max-jobs to 8
>> Exception in thread "main" java.lang.AssertionError: found trailing 0 
>> in chars
>>         at 
>> uk.me.parabola.imgfmt.app.labelenc.EncodedText.<init>(EncodedText.java:39) 
>>
>>         at 
>> uk.me.parabola.imgfmt.app.labelenc.AnyCharsetEncoder.encodeText(AnyCharsetEncoder.java:112) 
>>
>>         at 
>> uk.me.parabola.imgfmt.app.lbl.LBLFile.newLabel(LBLFile.java:132)
>>         at 
>> uk.me.parabola.imgfmt.app.lbl.PlacesFile.createPOI(PlacesFile.java:253)
>>         at 
>> uk.me.parabola.imgfmt.app.lbl.LBLFile.createPOI(LBLFile.java:172)
>>         at 
>> uk.me.parabola.mkgmap.build.MapBuilder.processPOIs(MapBuilder.java:670)
>>         at 
>> uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:325)
>>         at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:114)
>>         at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:62)
>>         at 
>> uk.me.parabola.mkgmap.main.Main.lambda$processFilename$1(Main.java:291)
>>         at 
>> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>>         at 
>> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) 
>>
>>         at 
>> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) 
>>
>>         at java.base/java.lang.Thread.run(Thread.java:829)
>>
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-dev at lists.mkgmap.org.uk
>> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev