[mkgmap-dev] check roundabouts

Mon Apr 12 17:27:42 BST 2021

Hi Gerd,

I have a largely completed change that extends the --check-roundabouts
option to become
--check-roundabouts=[all|loop|direction[:fix]|junctions|flares] and had made
fixing reversed roundabouts an optional part of the direction option

loop                  - check that roundabouts are formed from a single loop
with no forks or gaps
direction[:fix] - check and optionally fix the direction of travel around
the roundabout
junctions          - check that no more than one connecting highway joins at
each node
flares                - check that roundabout flare roads are one-way, are
in the right direction, and don't extend beyond the flare

However, separating the options completely allows for correction without
displaying any message if desired, so I will look at that and I will change
the reporting option name to --report-roundabout-issues as suggested, which
brings it into line with the other diagnostic options.

Also included in the change is code to more accurately try to identify
roundabout flares, as the existing code produces more false results than
wanted ones. It replaces --max-flare-length-ratio=NUM with
--roundabout-flare-rules-config=filename where the config file can contain a
set of rules for identifying flares.

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:gpetermann_muenchen at hotmail.com] 
Sent: 12 April 2021 16:10
To: Development list for mkgmap <mkgmap-dev at lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] logging

Hi Mike,

please have a look at the check-roundabouts and --check-roundabout-flares
code. I think we missed the fact that --check-roundabouts may change the
direction of roundabouts (in StyledConverter).
So, I think we need a new option like report-roundabout-issues=[NUM] and
another one for the reversing?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike
Baggaley <mike at tvage.co.uk>
Gesendet: Montag, 12. April 2021 17:02
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] logging

Hi Gerd,

In the attached patch there are a few improvements to messages as well as
some more use of logging:

In ImgFS, the message from the FileNotWritableException was displaying the
filename twice, so I have fixed that.
In TdbBuilder, I have removed an unnecessary log.error
In StyledConverter, I have added the synchronisation code for the removal of
duplicate messages
In O5mBinHandler, I have changed a thrown exception from IOException to
FormatException so that it gets handled by its callers

Cheers,
Mike