[mkgmap-dev] Removal of floodblocker generate-sea option

Wed Mar 17 15:30:39 GMT 2021

Hi Gerd

Without floodblocker, I don't think there is a need for 

mkgmap/reader/osm/SeaPolygonRelation which extends MultiPolygonRelation

Ticker

On Wed, 2021-03-17 at 14:37 +0000, Gerd Petermann wrote:
> Hi Ticker,
> 
> I don't see yet how floodblocker is related to MP processing?
> 
> Gerd
> 
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Mike Baggaley <mike at tvage.co.uk>
> Gesendet: Mittwoch, 17. März 2021 15:18
> An: 'Ticker Berkin'; 'mkgmap development'
> Betreff: Re: [mkgmap-dev] Removal of floodblocker generate-sea option
> 
> I don't use precomp-sea, but I don't use floodblocker either, so the
> suggestion is fine by me. It may however be worth displaying a
> warning if a tile appears to be flooded.
> 
> Cheers,
> Mike
> 
> -----Original Message-----
> From: Ticker Berkin [mailto:rwb-mkgmap at jagit.co.uk]
> Sent: 17 March 2021 09:28
> To: mkgmap development <mkgmap-dev at lists.mkgmap.org.uk>
> Subject: [mkgmap-dev] Removal of floodblocker generate-sea option
> 
> Hi all
> 
> I think it is time that that the floodblocker logic is removed.
> 
> I doubt if anyone uses it.
> 
> The recommended way to have sea is to use --precomp-sea and
> floodblocker is irrelevant to this.
> 
> Using the coastline data from the normal OSM input, the common sea
> problems are in tiles that extend beyond the extracted region, where
> coastline is incomplete (not reaching tile edges, or has gaps where
> there are estuaries) and floodblocker is no use in this case.
> 
> This could be done as part of the "faster-mp" branch as it removes an
> interface into MultiPolygonRelation, reducing the effort to
> restructure
> this.
> 
> Ticker
> 
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev