logo separator

[mkgmap-dev] Error in mkgmaps logging class?

From Steve Ratcliffe sr at parabola.me.uk on Mon Mar 15 14:18:00 GMT 2021

Hi Gerd

> I've noticed that
> log.isLoggable(Level.WARNING)
> always returns true when I don't use the -Dconfig.logging option for JRE . This is unexpected as calls to
> log.warn(...)
> don't produce any output in this case.
> The attached simple patch seems to fix this but I don't really understand the code.
> Maybe you forgot this change in http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=233 ?

Yes that sounds right, the level should be set to SEVERE

> In class MultiPolygonRelation we have quite a lot of methods which is meant to be skipped if logging is not enabled but because of this bug(?) the code is executed sometimes, maybe with side effects that I don't yet fully understand.

There shouldn't be any extra side effects, but it may be a little quicker.


More information about the mkgmap-dev mailing list