[mkgmap-dev] Error in mkgmaps logging class?

Mon Mar 15 08:52:25 GMT 2021

Hi Steve,

Please review: 
I've noticed that 
log.isLoggable(Level.WARNING)
always returns true when I don't use the -Dconfig.logging option for JRE . This is unexpected as calls to 
log.warn(...)
don't produce any output in this case.

The attached simple patch seems to fix this but I don't really understand the code.
Maybe you forgot this change in http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=233 ?

In class MultiPolygonRelation we have quite a lot of methods which is meant to be skipped if logging is not enabled but because of this bug(?) the code is executed sometimes, maybe with side effects that I don't yet fully understand.

Gerd

-------------- next part --------------
A non-text attachment was scrubbed...
Name: logger.patch
Type: application/octet-stream
Size: 410 bytes
Desc: logger.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20210315/6189e6ee/attachment-0001.obj>