[mkgmap-dev] improved diagnostics patch v2

Fri Jan 15 10:13:55 GMT 2021

HI Gerd, 

That implementation of toBrowseURL doesn't handle the case where originalId
is also a generated Id (e.g. the background areas generated in SeaGenerator
which do not relate to any OSM way).

How about:
                if (FakeIdGenerator.isFakeId(id))
                       return getBasicLogInformation();

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:gpetermann_muenchen at hotmail.com] 
Sent: 15 January 2021 07:07
To: Development list for mkgmap <mkgmap-dev at lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] improved diagnostics patch v2

Hi Mike,

didn't help for my case where way.toBrowseURL() is called for a way which
was generated from a multipolygon. (WrongAngleFixer line 688)

I think I can replace toBrowseURL() with getBasicLogInformation() there and
in all other debug.log() messages. I think the urls are not helping anyway
when debugging. There are also some duplicated blanks in log messages.

My current version of toBrowseURL() looks like this:
        public String toBrowseURL() {
                if (FakeIdGenerator.isFakeId(id))
                        return "generated from " + getOrigElement() + " " +
originalId;

                return "http://www.openstreetmap.org/" + kind() + "/" + id;
        }

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike
Baggaley <mike at tvage.co.uk>
Gesendet: Donnerstag, 14. Januar 2021 12:59
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] improved diagnostics patch v2

HI Gerd,

I spotted a problem in Element.getBasicLogInformation if it is called on an
element that does not have an OSM Id. The attached patch fixes that. The
previous version only fixed it in Element.toBrowseURL.

Cheers,
Mike

-----Original Message-----
From: Mike Baggaley [mailto:mike at tvage.co.uk]
Sent: 13 January 2021 20:53
To: 'Development list for mkgmap' <mkgmap-dev at lists.mkgmap.org.uk>
Subject: RE: [mkgmap-dev] improved diagnostics patch v2

HI Gerd,

The attached updated patch fixes the problem of a URL for a way having a
relation id rather than an way id. It also handles the case where a way is
generated without an original OSM id (as happens in the sea generator), so
there is no valid URL.

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:gpetermann_muenchen at hotmail.com]
Sent: 13 January 2021 09:58
To: Development list for mkgmap <mkgmap-dev at lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] improved diagnostics patch v2

Hi Mike,

I get some messages which are wrong:
FEIN: uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer
f:\osm\wildeshausen.o5m: removing obsolete point on almost straight segment
in way  http://www.openstreetmap.org/way/1187315 at
http://www.openstreetmap.org/?mlat=52.940356&mlon=8.340912&zoom=17

instead of
FEIN: uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer
f:\osm\wildeshausen.o5m: removing obsolete point on almost straight segment
in way  http://www.openstreetmap.org/way/4611686018427387930 at
http://www.openstreetmap.org/?mlat=52.940356&mlon=8.340912&zoom=17

The way in question is w78508173 which is a member of relation 1187315. So,
the new code reports the relation id as way id.

I also see unexpected changes in the img files. Don't know yet why. I assume
toString() is used to identify objects somewhere.

Gerd