[mkgmap-dev] Error in my style with Version mkgmap-r4136

Thu Mar 29 08:11:54 BST 2018

Hi Steve,

yes, that looks much clearer.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve at parabola.me.uk>
Gesendet: Mittwoch, 28. März 2018 18:53:22
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] Error in my style with Version mkgmap-r4136

Hi Gerd

> looks good for me, although you may simplify the code in isIndexable():
> a) The expression ((ValueOp) op.getFirst()).isIndexable() appears three times
> b) the term (op.getSecond().isType(VALUE) || op.getSecond().isType(FUNCTION) appears two times and I wonder why it is needed.
> Do you have an example? The unit tests don't fail when I remove it.

OK a lot of that is not needed any more.

The attached patch returns isIndexable() to its simplest form and
all the other code is changed to fit.

Steve