[mkgmap-dev] Bug in Road Merging - actually doubling roads.

Thu Mar 1 16:30:55 GMT 2018

Okay - no-merge-lines makes no difference, also removing
addArcsToMajorRoads();
function makes no difference. And I just noticed - the patch does not work.
It works in it's own way - but not achieving the result that is needed.
Whatever I do - I still end up with 6 routable lines.

I guess the patch checks for each road that it is not more than 4 times in
the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map,
2 from the east not supposed, and 3 from the south, not supposed). (always
using gpsmapedit to check results).

On 1 March 2018 at 12:33, Gerd Petermann <gpetermann_muenchen at hotmail.com>
wrote:

> Hi Felix,
>
> okay, now I have it. Doesn't help much because the debug routine simply
> creates OSM ways for the data, and since your style creates many
> duplicated ways JOSM cannot handle the data:-(
> Maybe I'll change the debug code to create unique way ids and store the
> osm id in a tag later.
>
> Did you try if --no-mergeroads helps?
> Another option for you special style might be to disable the code that
> adds arcs for major roads.
> Maybe try to comment this line in line 270 in RoadNetwork.java:
> addArcsToMajorRoads();
>
> This is improving long distance routing for normal maps but might cause
> trouble with styles for cycling.
>
> Gerd
>
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von
> Felix Hartmann <extremecarver at gmail.com>
> Gesendet: Donnerstag, 1. März 2018 11:21:57
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
>
> Sorry typo: https://openmtbmap.org/debug_orig_map2.zip will work.
>
> On 1 Mar 2018 10:40 am, "Gerd Petermann" <gpetermann_muenchen at hotmail.com
> <mailto:gpetermann_muenchen at hotmail.com>> wrote:
> Hi Felix,
>
> tried a few times now but always got "404 Not Found".
> Please upload the file to http://files.mkgmap.org.uk/
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-
> dev-bounces at lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <
> extremecarver at gmail.com<mailto:extremecarver at gmail.com>>
> Gesendet: Mittwoch, 28. Februar 2018 21:55:16
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
>
> well finally could access my server again -- maps with the additional
> patch and debug file here:
> https://openmtbmap.org/debug_org_map2.zip
>
> On 28 February 2018 at 20:54, Felix Hartmann <extremecarver at gmail.com<
> mailto:extremecarver at gmail.com><mailto:extremecarver at gmail.com<mailto:
> extremecarver at gmail.com>>> wrote:
> Hi Gerd
> will do so tomorrow - cannot get onto my server since 2 hours (if I still
> cannot get on the server I will compile locally on Friday).
>
> As for the mail - yes I read it and replied in here.
> I think the order for most would be the opposite - throw away the first
> roads, not the last! Usually you would first put in routes, bridges and so
> on into your map - then maybe lines just for visualisation - all with
> continue, and then finally put in the road itself without continue.
> For my maps the best approach in doubt would be:
> 1. check if one segment is completely double (same type - fully covered by
> the same type).
> 2. Throw away 0x13 (I use this invisibly for routing)
> 3. Throw away those roads created first if still needed.
>
>
> Felix
>
> On 28 February 2018 at 18:49, Gerd Petermann <gpetermann_muenchen at hotmail.
> com<mailto:gpetermann_muenchen at hotmail.com><mailto:g
> petermann_muenchen at hotmail.com<mailto:gpetermann_muenchen at hotmail.com>>>
> wrote:
> Hi Felix,
>
> please try also to compile with this additional patch and produce the
> debug info again.
> The patch simply executes the road merging before the angle fixing. I am
> not sure
> why we don't always do it in this order.
>
> By the way, did you read this post?
> http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk<mailto:mkgmap-
> dev-bounces at lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@
> lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces at lists.mkgmap.org.uk>>> im
> Auftrag von Felix Hartmann <extremecarver at gmail.com<mailto:
> extremecarver at gmail.com><mailto:extremecarver at gmail.com<mailto:
> extremecarver at gmail.com>>>
> Gesendet: Mittwoch, 28. Februar 2018 18:29:05
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
>
> Oh thanks - I did not notice that.
>
> Here is now the orig_map compiled with the patched mkgmap. Hope this helps
> you.
> https://openmtbmap.org/debug_orig_map.zip
>
>
> Felix
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk
> ><mailto:mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.
> mkgmap.org.uk>>
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
>
>
> --
> Felix Hartman - Openmtbmap.org & VeloMap.org
> Schusterbergweg 32/8
> 6020 Innsbruck
> Austria - Österreich
>
>
>
> --
> Felix Hartman - Openmtbmap.org & VeloMap.org
> Schusterbergweg 32/8
> 6020 Innsbruck
> Austria - Österreich
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk<mailto:mkgmap-dev at lists.mkgmap.org.uk>
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>

-- 
Felix Hartman - Openmtbmap.org & VeloMap.org
Schusterbergweg 32/8
6020 Innsbruck
Austria - Österreich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180301/97ffc12f/attachment.html>