[mkgmap-dev] AssertionError with custom style and --housenumbers

Sat Apr 1 11:53:28 BST 2017

OK - again, I misunderstood something.

Ticker

On Sat, 2017-04-01 at 10:09 +0000, Gerd Petermann wrote:
> Hi Ticker,
> 
> I don't think that my change is much different to yours.
> The current code is
>                                 if (lat != lastLat || lon != lastLon
> ||
>                                     (checkPreserved && (p instanceof
> CoordNode || p.preserved())))
> I was not sure if we have a case where a CoordNode doesn't return
> true for a call of p.preserved(), so I kept that.
> 
> Gerd
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Samstag, 1. April 2017 12:01:57
> An: mkgmap-dev at lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] AssertionError with custom style and -
> -housenumbers
> 
> Hi Gerd
> 
> I think your fix will remove most of the benefits of the
> PredictFilterPoints, by keeping all original map coords.
> My mistake was assuming that only original points were candidates for
> preserving but this looks not to be true. It looks like housenumber
> processing generates points to be kept.
> 
> It should be:
> ...
>                                 if (lat != lastLat || lon !=
> lastLon ||
>                                     (checkPreserved &&
> p.preserved()))
>                                         ++numPoints;
> 
> Ticker
> 
> On Sat, 2017-04-01 at 05:39 +0000, Gerd Petermann wrote:
> > Hi Carlos,
> > 
> > this problem is fixed with r3874.  It was introduced with the merge
> > from the split-shape branch.
> > Not sure why it only occurs with this special style.
> > 
> > Gerd
> > ________________________________________
> > Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> > von Carlos Dávila <cdavilam at orangecorreo.es>
> > Gesendet: Freitag, 31. März 2017 20:17:47
> > An: Development list for mkgmap
> > Betreff: [mkgmap-dev] AssertionError with custom style and -
> > -housenumbers
> > 
> > I'm getting the error below compiling a single tile with the
> > following
> > command:
> > 
> > java -Xmx2500m -ea -jar mkgmap.jar --output-dir=./tmp
> > --bounds=bounds.zip --precomp-sea=sea.zip --max-jobs --route -
> > -latin1
> > --code-page=1252 --index --housenumbers --style=truck 55139114.o5m
> > 
> > java.lang.AssertionError
> >          at
> > uk.me.parabola.imgfmt.app.net.RoadIndex.write(RoadIndex.java:45)
> >          at
> > uk.me.parabola.imgfmt.app.net.RoadDef.writeLevelDivs(RoadDef.java:3
> > 61
> > )
> >          at
> > uk.me.parabola.imgfmt.app.net.RoadDef.writeNet1(RoadDef.java:230)
> >          at
> > uk.me.parabola.imgfmt.app.net.NETFile.write(NETFile.java:66)
> >          at
> > uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:263)
> >          at
> > uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107)
> >          at
> > uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69)
> >          at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263)
> >          at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259)
> >          at
> > java.util.concurrent.FutureTask.run(FutureTask.java:266)
> >          at
> > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecuto
> > r.
> > java:1142)
> >          at
> > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecut
> > or
> > .java:617)
> >          at java.lang.Thread.run(Thread.java:745)
> > 
> > Removing --housenumbers tile compiles fine. What is causing the
> > error
> > is
> > the absence of the following rule in lines file:
> > 
> > # Mop up any unrecognised highway types
> > highway=* & area!=yes [0x07 road_class=0 road_speed=0 resolution
> > 23]
> > 
> > Input data: http://alternativaslibres.org/files/tmp/55139114.o5m
> > 
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev