[mkgmap-dev] To do: If-Then-Else

Wed Feb 15 08:15:19 GMT 2017

Hi Andrzej,

I've fixed the initial problem with r3805, attached is a v3 of the patch which is simpler and handles null values.
Allthough this is not related to if-then I'd prefer to add this to the branch as it is a step which adds new functionality.
OK?

Gerd
________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen at hotmail.com>
Gesendet: Dienstag, 14. Februar 2017 12:33:33
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] To do: If-Then-Else

Hi Andrzej,

ah, yes, seems that getUsedTags() may return a collection containing null as key.
I'll try to fix that, do not yet know where.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej at poczta.onet.pl>
Gesendet: Dienstag, 14. Februar 2017 12:12:39
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] To do: If-Then-Else

Hi Gerd,

it looks like your patch doesn't cooperate with my changes to default
style (about aeroway). If I apply both patches, then mkgmap crashes
using internal style. If I apply only your patch and use my version of
default style in a folder, then I get following crash (no style-option
used):

f:\OSM\_Test>java -Xmx12000m -jar e:\OSM\Tools\mkgmap-test\mkgmap.jar
--code-page=1252 --preserve-element-order --output-dir=img
--style-file=default1   --index --make-poi-index --route --housenumbers
29483018.osm.pbf 29483015.osm.pbf
Time started: Tue Feb 14 12:06:59 CET 2017
java.lang.NullPointerException
         at java.util.TreeMap.compare(Unknown Source)
         at java.util.TreeMap.put(Unknown Source)
         at java.util.TreeSet.add(Unknown Source)
         at java.util.AbstractCollection.addAll(Unknown Source)
         at java.util.TreeSet.addAll(Unknown Source)
         at java.util.TreeSet.<init>(Unknown Source)
         at
uk.me.parabola.mkgmap.osmstyle.StyledConverter.parseStyleOption(StyledConverter.java:249)
         at
uk.me.parabola.mkgmap.osmstyle.StyledConverter.<init>(StyledConverter.java:219)
         at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.createConverter(OsmMapDataSource.java:293)
         at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.setupHandler(OsmMapDataSource.java:187)
         at
uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinMapDataSource.java:49)
         at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:138)
         at
uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154)
         at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52)
         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:265)
         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:261)
         at java.util.concurrent.FutureTask.run(Unknown Source)
         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown
Source)
         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
Source)
         at java.lang.Thread.run(Unknown Source)
Exiting - if you want to carry on regardless, use the --keep-going option
Number of ExitExceptions: 1
Time finished: Tue Feb 14 12:06:59 CET 2017
Total time taken: 266ms

--
Best regards,
Andrzej

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: style-option_v3.patch
Type: application/octet-stream
Size: 7875 bytes
Desc: style-option_v3.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20170215/2824fecf/attachment-0001.obj>