[mkgmap-dev] unit test fails in branch

Wed Feb 8 17:40:40 GMT 2017

Hi Ticker,

I've just executed at clean dist test with r3795 and got no problem.
Note that the TRE size also depends on the value returned by Version.getSvnVersion();

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
Gesendet: Mittwoch, 8. Februar 2017 18:24:20
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] unit test fails in branch

Hi Gerd

Strange - I don't get this failure, but there was a place were I set
something to null because there wasn't a good value for it and I
thought it would be a mistake for later code to use it. I've set it to
something harmless.

but I still get:
junit.framework.AssertionFailedError: TRE size
Expected: between <768> and <772>
     but: was <773>
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
  at func.SimpleTest.testPolish(SimpleTest.java:104)

I thought you'd just committed a change to stop this.

Ticker

On Wed, 2017-02-08 at 16:23 +0000, Gerd Petermann wrote:
> Hi Ticker,
>
> I've fixed another one with r3794, but on my (Windows) machine
> TestSourceTest fails:
> Time started: Wed Feb 08 17:22:56 CET 2017
> java.lang.NullPointerException
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:159)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:187)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:181)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:181)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:181)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:181)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.addAreasToList(MapSplitter.ja
> va:181)
>         at
> uk.me.parabola.mkgmap.build.MapSplitter.split(MapSplitter.java:113)
>         at
> uk.me.parabola.mkgmap.build.MapBuilder.makeMapAreas(MapBuilder.java:6
> 98)
>         at
> uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:234)
>         at
> uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107)
>         at
> uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69)
>         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:265)
>         at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:1)
>         at java.util.concurrent.FutureTask.run(Unknown Source)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown
> Source)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
> Source)
>         at java.lang.Thread.run(Unknown Source)
> Exiting - if you want to carry on regardless, use the --keep-going
> option
> Number of ExitExceptions: 1
>
> Gerd
> ________________________________________
> Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag
> von Ticker Berkin <rwb-mkgmap at jagit.co.uk>
> Gesendet: Mittwoch, 8. Februar 2017 16:58:24
> An: mkgmap-dev at lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] unit test fails in branch
>
> Fixed this.
>
> svn commit comment should have been:
> "Merge in trunk and cope with mapSource without bounds"
>
> Ticker
>
>
> On Wed, 2017-02-08 at 08:46 +0000, Gerd Petermann wrote:
> > Hi Ticker,
> >
> > please check:
> > The unit test testCombiningSupps() in class GmapsuppTest fails:
> > SCHWERWIEGEND (MapFailedException): (thrown in Area.split()) Area
> > split shift align problems
> > uk.me.parabola.imgfmt.MapFailedException: Area split shift align
> > problems
> >       at uk.me.parabola.imgfmt.app.Area.split(Area.java:174)
> >       at
> > uk.me.parabola.mkgmap.build.MapArea.split(MapArea.java:206)
> >       at
> > uk.me.parabola.mkgmap.build.MapSplitter.splitMaxSize(MapSplitter.ja
> > va
> > :234)
> >       at
> > uk.me.parabola.mkgmap.build.MapSplitter.split(MapSplitter.java:103)
> >       at
> > uk.me.parabola.mkgmap.build.MapBuilder.makeMapAreas(MapBuilder.java
> > :6
> > 98)
> >       at
> > uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:234)
> >       at
> > uk.me.parabola.mkgmap.combiners.OverviewBuilder.writeOverviewMap(Ov
> > er
> > viewBuilder.java:184)
> >       at
> > uk.me.parabola.mkgmap.combiners.OverviewBuilder.onFinish(OverviewBu
> > il
> > der.java:91)
> >       at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:620)
> >       at
> > uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReader.
> > ja
> > va:128)
> >       at uk.me.parabola.mkgmap.main.Main.mainStart(Main.java:138)
> >       at
> > uk.me.parabola.mkgmap.main.Main.mainNoSystemExit(Main.java:105)
> >       at
> > func.files.GmapsuppTest.testCombiningSupps(GmapsuppTest.java:129)
> >       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> >       at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> >       at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> >       at java.lang.reflect.Method.invoke(Unknown Source)
> >       at
> > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framewo
> > rk
> > Method.java:50)
> >       at
> > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveC
> > al
> > lable.java:12)
> >       at
> > org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework
> > Me
> > thod.java:47)
> >       at
> > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeM
> > et
> > hod.java:17)
> >       at
> > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefore
> > s.
> > java:26)
> >       at
> > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.
> > ja
> > va:27)
> >       at
> > org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> >       at
> > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassR
> > un
> > ner.java:78)
> >       at
> > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassR
> > un
> > ner.java:57)
> >       at
> > org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> >       at
> > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> >       at
> > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> >       at
> > org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> >       at
> > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> >       at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> >       at
> > org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUni
> > t4
> > TestReference.java:86)
> >       at
> > org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecuti
> > on
> > .java:38)
> >       at
> > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(Rem
> > ot
> > eTestRunner.java:459)
> >       at
> > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(Rem
> > ot
> > eTestRunner.java:678)
> >       at
> > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTe
> > st
> > Runner.java:382)
> >       at
> > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteT
> > es
> > tRunner.java:192)
> > Number of ExitExceptions: 1
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev