[mkgmap-dev] Name-tag-list parameter not used in relations processing

Sun Mar 30 09:23:42 BST 2014

Hi Paco,

thanks for the details, that helped a lot.

I found out that I have to patch RelationStyleHook, not StyledConverter.
patch v1 works, but the apply rules are processed before,
so it has not much effect ;-)

Attached is a version 2 of the patch, a compiled binary based on r3138 is here:
http://files.mkgmap.org.uk/download/195/mkgmap.jar

Gerd

> Date: Sat, 29 Mar 2014 21:54:29 +0100
> From: paco.tyson at free.fr
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] Name-tag-list parameter not used in relations	processing
> 
> Selon GerdP <gpetermann_muenchen at hotmail.com>:
> 
> > Hi Paco,
> >
> > you can try it, I've uploaded the binary :
> > http://files.mkgmap.org.uk/download/192/mkgmap.jar
> >
> > Gerd
> 
> Hi Gerd,
> I'm afraid the patch isn't effective.
> 
> For your information, the relations file contains :
> 
> network=icn & state!=proposed {
> 	apply {
> 		set icn_from_relation=yes;
> 		set icn_name='${name}';
> 		set icn_ref='${ref}';
> 	};
> 	echotags "Relation ICN";
> }
> 
> and the corresponding lines file :
> highway=* & icn_from_relation=yes  {name '${icn_ref}
> (${icn_name|not-equal:icn_ref})' | '${icn_ref}'; echotags "ICN way"; }  [0x00
> resolution 15-15 continue]
> 
> 
> 
> Mkgmap r3116, without name-tag-list parameter set :
> [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part
> France,ref=EV3,network=icn] Relation ICN
> [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part
> France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France
> métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo
> 3 - part
> France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes]
> ICN way
> 
> 
> 
> Mkgmap r3116, name-tag-list parameter set to name:fr,name,int_name :
> [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part
> France,name:fr=La route des pèlerins - portion France,ref=EV3,network=icn]
> Relation ICN
> [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part
> France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France
> métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo
> 3 - part
> France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes]
> ICN way
> 
> 
> 
> Mkgmap r3118, with jar file overwritten with your patched jar, without
> name-tag-list-parameter:
> [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part
> France,ref=EV3,network=icn] Relation ICN
> [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part
> France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France
> métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo
> 3 - part
> France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes]
> ICN way
> 
> 
> Mkgmap r3118, with jar file overwritten with your patched jar, name-tag-list
> parameter set to name:fr,name,int_name :
> [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part
> France,name:fr=La route des pèlerins - portion France,ref=EV3,network=icn]
> Relation ICN
> [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part
> France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France
> métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo
> 3 - part
> France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes]
> ICN way
> 
> 
> What I want is to get for way 254539829 the tag "mkgmap:label:1=La route des
> pèlerins - portion France". So I expect the relation to automatically get the
> tag "name=La route des pèlerins - portion France".
> Or did I misunderstood the way this parameter works ?
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20140330/000655f2/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rel-name-tag-v2.patch
Type: application/octet-stream
Size: 1212 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20140330/000655f2/attachment-0001.obj>