[mkgmap-dev] Unit tests in trunk fail

Sun Jan 5 13:20:45 GMT 2014

Hi WanMil,

it's a unit test regarding the style finalizer section which fails and I don't know why.

reg. RoadMerger:
it makes no sense to create closed ways because we would split them again later in StyledConverter.
I don't understand the idea about roundabouts.
If one is divided into 4 parts you can do 2 merges without closing it, no matter which 
parts you connect first, and you should always get 2 remaining parts. Assumes part a,b,c and d:
a+b and c+d or 
a+b and a_b + c or 
b+c and d+a  or 
b+c and b_c + d or
b+c and a + b_c or 
...

Gerd 

> Date: Sun, 5 Jan 2014 12:37:09 +0100
> From: wmgcnfg at web.de
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] Unit tests in trunk fail
> 
> Hi Gerd,
> 
> I think I found the problem:
> 
> // check if merging would create a closed way - which should not
> // be done (why? WanMil)
> if (cStart == cOtherEnd) {
>     return false;
> }
> 
> The RoadMerger avoids to create closed roads. In case the roads are not 
> merged in exactly the same order this is the reason for different merge 
> results due to roundabouts. In case a roundabout is divided in multiple 
> ways the number of merged ways is random.
> 
> At the moment I have no time to check that more in detail but I think 
> the code listed above can be removed.
> 
> WanMil
> 
> > Hi WanMil,
> >
> > please have a look, I don't fully understand why.
> >
> > Gerd
> >
> >
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20140105/0e919913/attachment.html>