[mkgmap-dev] [PATCH v1] Decide in style file if a way is closed automatically

Fri Oct 26 16:22:51 BST 2012

> Ok, I have runned the patch on a Benelux extract with only waterways now.
> In the log file I see only SEVERE (StyledConverter): splitter\map.osm: Use line rules only for WAY:
> There are no lines saying "Use both rules for..." altough there are some waterways that are converted as polygon.
> So the interesting ways are seemed to filtered out of these warnings and that is not what you have intended?

I see: the message "Use both rules..." is printed out only if the way is 
not closed and both endpoints are outside the bounding box. So it is 
quite seldom. Anyhow I wonder why you don't see such a message. The 
message is generated before the style files are evaluated so your style 
rules have no influence on if the message is printed or not.

Do you think the naming of the extra tags mkgmap:closed and 
mkgmap:autoclosing is good? Or do you have a better naming which is more 
intuitive? It's better to change that before committing :-)

WanMil