[mkgmap-dev] [PATCH v1] Using name-tag-list for country names

Mon Oct 10 22:42:41 BST 2011

El 10/10/11 22:43, WanMil escribió:
> Am 10.10.2011 22:34, schrieb Carlos Dávila:
>> El 10/10/11 21:28, WanMil escribió:
>>>> El 08/10/11 20:33, WanMil escribió:
>>>>> Up to now the names of the countries were taken from the
>>>>> LocatorConfig.xml file no matter what has been configured in the
>>>>> name-tag-list option.
>>>>> But the name-tag-list option was used to get the country names from
>>>>> the precompiled bounds which causes a problem if country name in the
>>>>> special language is not contained in the LocatorConfig.xml.
>>>>>
>>>>> The patch now uses the name-tag-list consistently for all places where
>>>>> country names are standardized.
>>>>>
>>>>> Additionally the values in the LocatorConfig.xml are automatically
>>>>> completed by all name tags of the precompiled boundaries.
>>>>>
>>>>> http://files.mkgmap.org.uk/detail/37 links to r2047 including this patch.
>>>> I have tested your patch to build my India map, but get the same errors
>>>> than without it, plus an new warning from LocatorConfig (see below).
>>>> Additionally, LocationHook errors with patched mkgmap show names in
>>>> local languages, despite the use of name-tag-list=int_name,name:en,name
>>> Carlos,
>>> it seems that mkgmap does not have access to a LocatorConfig.xml. The
>>> countries listed in your log are contained in the LocatorConfig.xml
>>> provided with mkgmap so they should be found.
>>> Did you modify the LocatorConfig.xml file?
>> No, I use the one from trunk. Within the jar file it's placed in the
>> root directory. I extracted it from the jar and is exactly the same that
>> the one in trunk.
>> Looking in other logs I see something is going wrong also with other
>> countries. For example, compiling Spain I get warnings about "Algérie"
>> and "Andorra" which are also in LocatorConfig, but not about Spain,
>> Portugal or France.
> Can you please test it without any modifications to the LocatorConfig?
> So please remove all LocatorConfig.xml files in your mkgmap environment
> so that only the one that is provided with the mkgmap build can be used.
I did it, compiled with your patched mkgmap and all LocatorConfig 
warnings went away. Now I have to rebuild my environment to get it 
working for further tests, but won't have a chance until next Thursday 
or Friday.
> Bye the way: if you want to compile maps for the region India it might
> be a good idea to fix the boundary of India and Pakistan. They are
> broken and are not contained in any precompiled boundary.
I know it is broken, but I don't want to break out a war in such a hot 
region by putting the border in the wrong place.;-)
>>>> patched mkgmap log:
>>>> 2011/10/09 22:31:02 ADVERTENCIA (LocatorConfig): 55180002.osm.pbf:
>>>> Cannot find country with tags [name:de=Myanmar;
>>>> mkgmap:boundaryid=r50371; name:ru=Мьянма; name:sv=Myanmar;
>>>> admin_level=2; name:sk=Mjanmarsko; name:sl=Mjanmar; name:en=Burma;
>>>> ISO3166-1=mm; name:fr=Birmanie; type=boundary; boundary=administrative;
>>>> name:es=Myanmar; name=ပြည်ထောင်စုမြန်မာနိုင်ငံတော်‌]
>>>> 2011/10/09 22:31:02 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> ပြည်ထောင်စုမြန်မာနိုင်ငံတော်‌ not in locator config. Country may not be
>>>> assigned correctly.
>>>> 2011/10/09 22:31:02 ADVERTENCIA (LocatorConfig): 55180002.osm.pbf:
>>>> Cannot find country with tags [name:de=Bangladesch;
>>>> mkgmap:boundaryid=r184640; name:ru=Бангладеш; name:sv=Bangladesh;
>>>> admin_level=2; name:sk=Bangladéš; name:sl=Bangladeš; name:en=Bangladesh;
>>>> ISO3166-1=bd; type=boundary; name:hu=Banglades; boundary=administrative;
>>>> name:es=Bangladesh; name=বাংলাদেশ]
>>>> 2011/10/09 22:31:02 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> বাংলাদেশ not in locator config. Country may not be assigned correctly.
>>>> 2011/10/09 22:31:02 ADVERTENCIA (LocatorConfig): 55180002.osm.pbf:
>>>> Cannot find country with tags [name:de=Sri Lanka; name:ru=Шри-Ланка;
>>>> admin_level=2; ISO3166-1=lk; name:en=Sri Lanka; boundary=administrative;
>>>> name=ශ්‍රී ලංකා; name:fr=Sri Lanka; border_type=nation; type=boundary;
>>>> mkgmap:boundaryid=r536807]
>>>> 2011/10/09 22:31:02 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> ශ්‍රී ලංකා not in locator config. Country may not be assigned correctly.
>>>> 2011/10/09 22:31:02 ADVERTENCIA (LocationHook): 55180002.osm.pbf: Cannot
>>>> process boundary element because it contains no name and no zip tag.
>>>> [mkgmap:lies_in=2:r536807; addr:city=Nittambuwa; is_in:country=Sri
>>>> Lanka; place=village; boundary=administrative; is_in=Gampaha; Western
>>>> Province; Sri Lanka; landuse=residential; border_type=village;
>>>> mkgmap:boundaryid=w49967688]
>>>> 2011/10/09 22:31:02 ADVERTENCIA (LocatorConfig): 55180002.osm.pbf:
>>>> Cannot find country with tags [name:de=Indonesien;
>>>> mkgmap:boundaryid=r304751; name:ru=Индонезия; name:sv=Indonesien;
>>>> admin_level=2; ISO3166-1=id; name:en=Indonesia; type=multipolygon;
>>>> name:fr=Indonésie; boundary=administrative; name=Indonesia;
>>>> border_type=nation; name:es=Indonesia]
>>>> 2011/10/09 22:31:02 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> Indonesia not in locator config. Country may not be assigned correctly.
>>>>
>>>> trunk log:
>>>> 2011/10/09 22:26:34 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> Burma not in locator config. Country may not be assigned correctly.
>>>> 2011/10/09 22:26:34 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> Bangladesh not in locator config. Country may not be assigned correctly.
>>>> 2011/10/09 22:26:34 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> Sri Lanka not in locator config. Country may not be assigned correctly.
>>>> 2011/10/09 22:26:34 ADVERTENCIA (LocationHook): 55180002.osm.pbf: Cannot
>>>> process boundary element because it contains no name and no zip tag.
>>>> [mkgmap:lies_in=2:r536807; addr:city=Nittambuwa; is_in:country=Sri
>>>> Lanka; place=village; boundary=administrative; is_in=Gampaha; Western
>>>> Province; Sri Lanka; landuse=residential; border_type=village;
>>>> mkgmap:boundaryid=w49967688]
>>>> 2011/10/09 22:26:34 GRAVE (LocationHook): 55180002.osm.pbf: Country name
>>>> Indonesia not in locator config. Country may not be assigned correctly.