[mkgmap-dev] [PATCH v1] mp improved tag handling

Thu Jan 28 20:07:56 GMT 2010

Marko,

> On Thu, Jan 28, 2010 at 08:56:42PM +0100, WanMil wrote:
> > Current mp implementation does not remove polygon tags from unclosed  
> > ways. I have observed that the unclosed polygons sometimes are closed in  
> > a later step of mkgmap. This causes flooding of areas around seas.  
> > Finnland is a great test area for this.
> 
> Thanks for testing Finland, WanMil!  Please wake me up when it mostly works,
> and I will enable generate-sea for my map, and flood you with further bug
> reports if needed. :-)

What happens if you use polygons rather than multipolygon for the sea
generation? If it still floods with polygons, the problem is in the sea
code, not in MP code.

> > Attached patch removes all polygon tags from ways that are used in  
> > multipolygons.
> 
> I am happy to commit it for you, if someone gives positive feedback first.
> Or perhaps Mark can test and commit it?

I will be happy to commit it when I understand what it does, I will
look at it soon.

Mark