[mkgmap-dev] oneway=reverse handling broken.

Fri Jan 22 16:20:04 GMT 2010

On 22.01.2010 17:10, Steve Ratcliffe wrote:
> Hi Felix
>
>    
>> See below for an example that does not work. It works with 1497, but
>> 1498 breaks it.
>> highway=*&  copy=99&  mtb:scale:uphill!=5&  mtb:scale:uphill!=4 { set
>> dontadd=yes; set taxi=no; set dontadd=oneway; set mkgmap:unpaved=1 }
>> [0x10711 resolution 21 continue with_actions] *output*
>>      
> Revision 1498 didn't change anything to do with continue or oneway as far
> as I can tell.  You are just discovering the problem with the styles
> on trunk that the actions are run in an arbitary order.  Although you
> can work around that to get something that sort of works, any
> change at all in the code is likely to break the workarounds, because
> the actions will now run in a different order.  This doesn't happen on
> the style branch (or if it did it would be a bug).
>    
Before [continue with_actions] worked with auxiliary tags no matter how 
much you mistreated it. Since 1500 this is broken. And oneway behaviour 
got completly random.
> I am certain that r1498 would not have changed the way your rules
> worked with the strict ordering as on the style branch
> (except perhaps for performance, but that could be fixed).
>
> So what I will do is revert 1498 on trunk and then put the patch in to
> the style branch instead.  Is that OK?  Once the style branch is
> merged and settled you should never have to spend so much time
> changing your rules again.
>
> Regards,
>
> ..Steve
>    
Oh sorry, I meant 1488 (though 1498 maybe too). 1487 was definitly still 
working and only had one bug:
keya=123 [continue]
keya=123 [continue] -- no output.

Everything else worked correctly. Sinde 1500 it simply got 
unpredictable. The lines file is NOT read in order anymore for [continue]

Best would be to revert to 1487 from the style rules, then change the 
conditional rules to work like [continue with_action] but without tpye, 
and dont't fix
keya=123 [continue]
keya=123 [continue] -- no output

-- My not correctly working attempts to overcome this meant 50% more 
memory use, and around 40-100% more rendering time. The above problem 
can easily be fixed by doing
keya=123 {set keynew1=...; set keynew2=.... ; set keynew3=.... [continue 
with_actions]
keynew1= ...... [continue]/[continue with_actions].
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>    