[mkgmap-dev] [mkgmap-svn] Commit: r1488: RuleFileReader.optimiseAndSaveBinaryOp(): Try to be symmetric.

Mon Jan 18 21:31:07 GMT 2010

Hi Steve,

On Mon, Jan 18, 2010 at 05:09:05PM +0000, Steve Ratcliffe wrote:
> I produced the attached patch which makes all the previous examples
> compile (apart from the plain a~b example).

Great!  The algorithm looks OK to me.

I have some remarks about it, using stricter type casts, adding missing
static qualifiers and adding or updating some comments, and replacing an
"assert false" with an exception (in case someone runs with assertions
disabled and the code is rearranged so that the assertion would be reached).  

Your patch with my revisions is attached.  Unfortunately, I was unable to
test on today's dump because of the NullPointerException that I mentioned
earlier.

	Marko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: style_rule-mm.patch
Type: text/x-diff
Size: 8280 bytes
Desc: not available
Url : http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20100118/5ddb8ac8/attachment.bin 