[mkgmap-dev] [PATCH v4] sea polygons

Thu Aug 20 20:42:23 BST 2009

Thanks for the feedback!

One trivial bug in the patch was that a tile with no shoreline at all 
got a sea polygon as "background".
This can be fixed by adding
        // don't do anything if there is no shoreline
        if (shoreline.size() == 0)
        return;
at the begin of generateSeaPolygon().

Am just testing with germany to see wether there are other problems with 
cut-off shorelines and will post an improved patch this weekend.

Best wishes
Christian

Clinton Gladstone schrieb:
> On Sun, Aug 16, 2009 at 12:49 AM, Christian
> Gawron<christian.gawron at gmx.de> wrote:
>
>   
>> With this version of the patch, the intersection of the bounding box and the
>> landmass does not have to be simply connected as in version 3 of the patch.
>>     
>
> Hm... I tried out this patch with a tiled map of Germany. The results
> were kind of amusing: pretty much all of Germany was flooded, with the
> exception of some areas around Lübeck. I suppose this is because I am
> using an extract (from Geofabrik) which cuts off coastline at the
> country border.
>
> Creating automatic sea polygons which will work in practice appears to
> be a rather non-trivial problem.
>
> Cheers and thanks for your work on this.
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>   