[mkgmap-dev] [PATCH] splitter with Java 5, was: exception in --list-styles

Tue Apr 21 06:37:36 BST 2009

On Tue, Apr 21, 2009 at 01:02:39AM +0200, Thilo Hannemann wrote:
>  			while ((line = br.readLine()) != null) {
>  				line = line.trim();
> -				if (line.isEmpty() || line.charAt(0) == '#')
> +				if ((line != null && line.length() == 0) || line.charAt(0) == '#')
>  					continue;
>
>  				Matcher matcher = pattern.matcher(line);

Why the line != null?  I wouldn't expect line.trim() to return null
or pattern.matcher() to accept null.

Also, would one public static Locale rootlocale in some class suffice?
Your patch is initializing rootlocale as a local variable, in two places.

	Marko