logo separator

[mkgmap-dev] [PATCH v1] Add --no-sort-roads option

From Marko Mäkelä marko.makela at iki.fi on Sun Apr 5 19:32:43 BST 2009

Hi Mark,

> > The patch you suggest would do a busy loop of all roads when
> > sortRoads==false.  Can you move the if (sortRoads) before the
> > for statement?  (Also the sortedRoads.size() check could be
> > skipped if !sortRoads, but that shouldn't cost much CPU, as
> > it will only be performed once.)
> 
> Have you seen the rd.writeRgnOffsets(rgn); at the top of the loop? That
> was the original content of the loop and it needs to stay.

Ah, I feel stupid.  Sorry for the noise.

	Marko



More information about the mkgmap-dev mailing list