<div dir="ltr">Could semi_con-v3.patch so the semi_connected tag be merged to trunk? It was compatible until now and is of really good use. Unfortunately - it conflicts with todays mkgmap update.<div>Sorry I forgot to answer back in 2017 confirming that it worked splendidly.</div><div><br></div><div>Felix</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 21 Sep 2017 at 15:02, Felix Hartmann <<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Thanks for v3 - on a quick tryrout it works well now. I have not found time (and won't until Tuesday next week) to give it a full check.<br></div>(and yes - I'm right now only using "none").<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 21 September 2017 at 11:56, Gerd Petermann <span dir="ltr"><<a href="mailto:GPetermann_muenchen@hotmail.com" target="_blank">GPetermann_muenchen@hotmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Felix,<br>
<br>
sorry, did not search for a solution for my example, what I wanted to point out is that the algo may produce unexpected results whenever the style adds multiple lines for one way with conflicting mkgmap:set_semi_connected_type values.<br>
<br>
In your style you can probably only use value "none". I wonder if anybody uses the variant with a value that gives a different type.<br>
<span><br>
Gerd<br>
<br>
<br>
________________________________________<br>
Von: mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk" target="_blank">mkgmap-dev-bounces@lists.mkgmap.org.uk</a>> im Auftrag von Felix Hartmann <<a href="mailto:extremecarver@gmail.com" target="_blank">extremecarver@gmail.com</a>><br>
</span>Gesendet: Donnerstag, 21. September 2017 11:16<br>
<span>An: Development list for mkgmap<br>
Betreff: Re: [mkgmap-dev] mkgmap:set_unconnected_type differentiate between connected on both sides or on one side only<br>
<br>
</span><span>As for your example - yes I guess only changing first occurence to 0x* - further occurences to none makes most sense. In general I think such a rule should not be used.<br>
<br>
So good practice would be either:<br>
highway=service & service=driveway {set<br>
mkgmap:set_semi_connected_type=none}<br>
highway=service [0x07 road_class=0 road_speed=2 resolution 22 continue]<br>
highway=service & oneway=yes [0x10106 resolution 24]<br>
<br>
or<br>
highway=service & service=driveway {set<br>
mkgmap:set_semi_connected_type=0x10806} [0x07 road_class=0 road_speed=2 resolution 22 continue]<br>
highway=service [0x07 road_class=0 road_speed=2 resolution 22 continue]<br>
highway=service & oneway=yes [0x10106 resolution 24]<br>
<br>
or<br>
highway=service & service=driveway {set<br>
mkgmap:set_semi_connected_type=0x10806}<br>
highway=service [0x07 road_class=0 road_speed=2 resolution 22 continue]<br>
highway=service & service=driveway {set<br>
mkgmap:set_semi_connected_type=0x10806}<br>
highway=service & oneway=yes [0x10106 resolution 24]<br>
<br>
but not your example and also not:<br>
highway=service & service=driveway {set<br>
mkgmap:set_semi_connected_type=0x10806} [0x07 road_class=0 road_speed=2 resolution 22 continue with_actions]<br>
highway=service [0x07 road_class=0 road_speed=2 resolution 22 continue]<br>
highway=service & oneway=yes [0x10106 resolution 24]<br>
<br>
<br>
<br>
</span><span>On 21 September 2017 at 11:10, Felix Hartmann <<a href="mailto:extremecarver@gmail.com" target="_blank">extremecarver@gmail.com</a><mailto:<a href="mailto:extremecarver@gmail.com" target="_blank">extremecarver@gmail.com</a>>> wrote:<br>
Somthing seems to be wrong with the patch:<br>
<br>
java.lang.NullPointerException<br>
at uk.me.parabola.mkgmap.osmstyle.StyledConverter.findUnconnectedRoads(StyledConverter.java:1970)<br>
at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:605)<br>
at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243)<br>
at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157)<br>
at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154)<br>
at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52)<br>
at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263)<br>
at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259)<br>
at java.util.concurrent.FutureTask.run(Unknown Source)<br>
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)<br>
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)<br>
at java.lang.Thread.run(Unknown Source)<br>
Could Not Find C:\OpenMTBMap\maps\ovm_6431*.img<br>
<br>
</span><div><div>On 19 September 2017 at 15:53, Gerd Petermann <<a href="mailto:gpetermann_muenchen@hotmail.com" target="_blank">gpetermann_muenchen@hotmail.com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com" target="_blank">gpetermann_muenchen@hotmail.com</a>>> wrote:<br>
Attached is v2 of the patch. It implements the removal of overlay lines when<br>
mkgmap:set_unconnected_type=none or mkgmap:set_semi_connected_type=none was<br>
found.<br>
<br>
I am still not sure what should be done if the tag has a value that gives<br>
another type instead of none.<br>
Assume your style uses<br>
highway=service & service=driveway {set<br>
mkgmap:set_semi_connected_type=0x10806}<br>
highway=service [0x07 road_class=0 road_speed=2 resolution 22 continue]<br>
highway=service & oneway=yes [0x10106 resolution 24]<br>
<br>
What would you expect for a semi connected way?<br>
We have 2 lines, the first is changed from 0x07 to 0x10806. It would not<br>
make much sense to change also the 2nd from 0x10106 to 0x10806.<br>
So, for now only the value none has an effect for the overlay line(s).<br>
<br>
semi_con-v2.patch<br>
<<a href="http://gis.19327.n8.nabble.com/file/t318326/semi_con-v2.patch" rel="noreferrer" target="_blank">http://gis.19327.n8.nabble.com/file/t318326/semi_con-v2.patch</a>><br>
<br>
Gerd<br>
<br>
<br>
Felix Hartmann-2 wrote<br>
> That sounds good<br>
><br>
> On Sep 19, 2017 11:23 AM, "Gerd Petermann" <<br>
<br>
> gpetermann_muenchen@<br>
<br>
> ><br>
> wrote:<br>
><br>
>> Hi Felix,<br>
>><br>
>> Felix Hartmann-2 wrote<br>
>> > Well I would like it to apply to non routable lines too - if continue<br>
>> > with_actions is used - basically just treat routable and non routable<br>
>> > lines<br>
>> > the same (the initial check should only look at routable lines though I<br>
>> > guess).<br>
>><br>
>> OK, I think I can change the code so that it stores the information<br>
>> whether<br>
>> or not a road<br>
>> is connected (or "semi-connected") once for each OSM way that is at least<br>
>> added once as a road.<br>
>> In a further step mkgmap would check each line for the existence of the<br>
>> mkgmap:set_unconnected_type tag and check if the corresponding OSM way is<br>
>> connected or not.<br>
<br>
<br>
<br>
<br>
<br>
--<br>
Sent from: <a href="http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html" rel="noreferrer" target="_blank">http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html</a><br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
</div></div><a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a>><br>
<div><div><a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
<br>
<br>
<br>
--<br>
Felix Hartman - Openmtbmap.org & VeloMap.org<br>
Schusterbergweg 32/8<br>
6020 Innsbruck<br>
Austria - Österreich<br>
<br>
<br>
<br>
--<br>
Felix Hartman - Openmtbmap.org & VeloMap.org<br>
Schusterbergweg 32/8<br>
6020 Innsbruck<br>
Austria - Österreich<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div><div>Felix Hartman - Openmtbmap.org & VeloMap.org<br></div>Schusterbergweg 32/8<br></div><div>6020 Innsbruck<br></div></div>Austria - Österreich</div></div></div></div>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div><div>Felix Hartman - Openmtbmap.org & VeloMap.org<br></div>Schusterbergweg 32/8<br></div><div>6020 Innsbruck<br></div></div>Austria - Österreich</div></div></div></div>