<div dir="ltr">Thanks Gerd, I will do some tests on Saturday and then report back. <div><br></div><div><br></div><div>Felix</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 8 March 2018 at 11:46, Gerd Petermann <span dir="ltr"><<a href="mailto:gpetermann_muenchen@hotmail.com" target="_blank">gpetermann_muenchen@hotmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Felix,<br>
<br>
attached is a patch that improves WrongAngleFixer.<br>
When both ways build a junction and both have another point close to that junction<br>
and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the<br>
same coordinate. This is what happened with these two nodes<br>
<a href="https://www.openstreetmap.org/node/1263658804" rel="noreferrer" target="_blank">https://www.openstreetmap.org/<wbr>node/1263658804</a><br>
<a href="https://www.openstreetmap.org/node/1195812701" rel="noreferrer" target="_blank">https://www.openstreetmap.org/<wbr>node/1195812701</a><br>
<br>
I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way<br>
overlap.<br>
I am not sure how this patch works with your style, please try it with r4131.<br>
<br>
A few special cases to look at:<br>
<a href="https://www.openstreetmap.org/way/208976154" rel="noreferrer" target="_blank">https://www.openstreetmap.org/<wbr>way/208976154</a> Coordinates: 38.4082747, 16.0787201<br>
<a href="https://www.openstreetmap.org/way/312642720" rel="noreferrer" target="_blank">https://www.openstreetmap.org/<wbr>way/312642720</a> Coordinates: 39.0259441, 8.5967561<br>
<a href="https://www.openstreetmap.org/way/148634420" rel="noreferrer" target="_blank">https://www.openstreetmap.org/<wbr>way/148634420</a> Coordinates: 41.981263, 12.4114831<br>
<span class=""><br>
Gerd<br>
<br>
______________________________<wbr>__________<br>
Von: mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-dev-bounces@lists.<wbr>mkgmap.org.uk</a>> im Auftrag von Felix Hartmann <<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.com</a>><br>
</span>Gesendet: Samstag, 3. März 2018 19:49:24<br>
<span class="">An: Development list for mkgmap<br>
Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.<br>
<br>
</span><span class="">well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years.<br>
If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why).<br>
<br>
(oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations).<br>
<br>
</span><span class="">On 3 March 2018 at 15:27, Gerd Petermann <<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@hotmail.<wbr>com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_<wbr>muenchen@hotmail.com</a>>> wrote:<br>
Hi Felix,<br>
<br>
</span><span class="">okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing<br>
with a normal mkgmap binary.<br>
<br>
Gerd<br>
<br>
<br>
______________________________<wbr>__________<br>
</span>Von: mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-dev-bounces@lists.<wbr>mkgmap.org.uk</a><mailto:<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-<wbr>dev-bounces@lists.mkgmap.org.<wbr>uk</a>>> im Auftrag von Gerd Petermann <<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@hotmail.<wbr>com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_<wbr>muenchen@hotmail.com</a>>><br>
<span class="">Gesendet: Samstag, 3. März 2018 11:34:24<br>
An: Development list for mkgmap<br>
Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.<br>
<br>
Hi Felix,<br>
<br>
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing.<br>
Something goes very wrong with this patched version.<br>
<br>
Gerd<br>
<br>
______________________________<wbr>__________<br>
</span>Von: mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-dev-bounces@lists.<wbr>mkgmap.org.uk</a><mailto:<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-<wbr>dev-bounces@lists.mkgmap.org.<wbr>uk</a>>> im Auftrag von Gerd Petermann <<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@hotmail.<wbr>com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_<wbr>muenchen@hotmail.com</a>>><br>
<span class="">Gesendet: Samstag, 3. März 2018 11:01:42<br>
An: Development list for mkgmap<br>
Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.<br>
<br>
Hi Felix,<br>
<br>
no, it is just special at this juntion because the other ways have 0x8 or 0x13.<br>
On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing<br>
for car (automotive) :-(<br>
I can reproduce a problem with "tour cycling", but I think that is expected with your style,<br>
because it avoids main roads by default. Maybe your users made the same error?<br>
<br>
You suggested to add<br>
route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue]<br>
to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file:<br>
type=route & route=hiking {<br>
apply {<br>
add route=hiking<br>
}<br>
}<br>
With that I see additional routable lines in the map and routing is more less broken at node 412440328 when<br>
I try to route from north to anywhere below the node , also the inverse way doesn't work.<br>
I tried different variants of the rule like other types or other road classes, always saw the same problem.<br>
I see working routing again when I remove way 130665733 from the input file and move node 1263658617<br>
down to 412440328 and merge them (see attached file).<br>
I'll try to find out why this is so special in this situation.<br>
<br>
ciao,<br>
Gerd<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
______________________________<wbr>__________<br>
</span><span class="">Von: mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-dev-bounces@lists.<wbr>mkgmap.org.uk</a><mailto:<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-<wbr>dev-bounces@lists.mkgmap.org.<wbr>uk</a>>> im Auftrag von Felix Hartmann <<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.com</a><<wbr>mailto:<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.com</a><wbr>>><br>
</span><span class="">Gesendet: Freitag, 2. März 2018 22:21:35<br>
An: Development list for mkgmap<br>
Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.<br>
<br>
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?<br>
<br>
</span><span class="">On 1 March 2018 at 18:55, Gerd Petermann <<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@hotmail.<wbr>com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_<wbr>muenchen@hotmail.com</a>><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">g<wbr>petermann_muenchen@hotmail.com</a><wbr><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@<wbr>hotmail.com</a>>>> wrote:<br>
Hi Felix,<br>
<br>
</span><span class="">okay, I think I can reproduce a routing problem on my Oregon with your map.<br>
I have a route that works from south to north but not in the reverse direction.<br>
I'll try to create a similar situation with a modified default style to find out<br>
what the problem is. My current prime suspect is the way with type 0x16.<br>
<br>
Gerd<br>
<br>
______________________________<wbr>__________<br>
</span>Von: mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-dev-bounces@lists.<wbr>mkgmap.org.uk</a><mailto:<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-<wbr>dev-bounces@lists.mkgmap.org.<wbr>uk</a>><mailto:<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkgmap-dev-bounces@<wbr>lists.mkgmap.org.uk</a><mailto:<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk">mkg<wbr>map-dev-bounces@lists.mkgmap.<wbr>org.uk</a>>>> im Auftrag von Felix Hartmann <<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.com</a><<wbr>mailto:<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.com</a><wbr>><mailto:<a href="mailto:extremecarver@gmail.com">extremecarver@gmail.<wbr>com</a><mailto:<a href="mailto:extremecarver@gmail.com">extremecarver@<wbr>gmail.com</a>>>><br>
<span class="">Gesendet: Donnerstag, 1. März 2018 18:09:02<br>
An: Development list for mkgmap<br>
Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.<br>
<br>
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.<br>
<br>
<br>
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.<br>
<br>
</span><div><div class="h5">On 1 March 2018 at 17:47, Gerd Petermann <<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@hotmail.<wbr>com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_<wbr>muenchen@hotmail.com</a>><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">g<wbr>petermann_muenchen@hotmail.com</a><wbr><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_muenchen@<wbr>hotmail.com</a>>><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpeterman<wbr>n_muenchen@hotmail.com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com"><wbr>gpetermann_muenchen@hotmail.<wbr>com</a>><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gpetermann_<wbr>muenchen@hotmail.com</a><mailto:<a href="mailto:gpetermann_muenchen@hotmail.com">gp<wbr>etermann_muenchen@hotmail.com</a>><wbr>>>> wrote:<br>
Hi Felix,<br>
<br>
Felix Hartmann-2 wrote<br>
> Okay - no-merge-lines makes no difference, also removing<br>
> addArcsToMajorRoads();<br>
> function makes no difference. And I just noticed - the patch does not<br>
> work.<br>
> It works in it's own way - but not achieving the result that is needed.<br>
> Whatever I do - I still end up with 6 routable lines.<br>
><br>
> I guess the patch checks for each road that it is not more than 4 times in<br>
> the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the<br>
> map,<br>
> 2 from the east not supposed, and 3 from the south, not supposed). (always<br>
> using gpsmapedit to check results).<br>
<br>
yes, that is what it does. Didn't you suggest something like that?<br>
<br>
You still did not tell me how I can reproduce a crash with this data, so I<br>
can only guess.<br>
I didn't see any routing issues so far with your maps, only the ugly<br>
rendering.<br>
Is this the only problem or is there really a routing issue?<br>
If yes, please let me know how to reproduce it.<br>
<br>
Gerd<br>
<br>
<br>
<br>
<br>
--<br>
Sent from: <a href="http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html" rel="noreferrer" target="_blank">http://gis.19327.n8.nabble.<wbr>com/Mkgmap-Development-<wbr>f5324443.html</a><br>
______________________________<wbr>_________________<br>
mkgmap-dev mailing list<br>
</div></div><a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><wbr><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-<wbr>dev@lists.mkgmap.org.uk</a><<wbr>mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>>><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-<wbr>dev@lists.mkgmap.org.uk</a><<wbr>mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-<wbr>dev@lists.mkgmap.org.uk</a><<wbr>mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>>>><br>
<div class="HOEnZb"><div class="h5"><a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/<wbr>mailman/listinfo/mkgmap-dev</a><br>
<br>
<br>
<br>
--<br>
Felix Hartman - Openmtbmap.org & VeloMap.org<br>
Schusterbergweg 32/8<br>
6020 Innsbruck<br>
Austria - Österreich<br>
______________________________<wbr>_________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><wbr><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-<wbr>dev@lists.mkgmap.org.uk</a><<wbr>mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>>><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/<wbr>mailman/listinfo/mkgmap-dev</a><br>
<br>
<br>
<br>
--<br>
Felix Hartman - Openmtbmap.org & VeloMap.org<br>
Schusterbergweg 32/8<br>
6020 Innsbruck<br>
Austria - Österreich<br>
______________________________<wbr>_________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><wbr><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/<wbr>mailman/listinfo/mkgmap-dev</a><br>
______________________________<wbr>_________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><wbr><mailto:<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.<wbr>mkgmap.org.uk</a>><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/<wbr>mailman/listinfo/mkgmap-dev</a><br>
<br>
<br>
<br>
--<br>
Felix Hartman - Openmtbmap.org & VeloMap.org<br>
Schusterbergweg 32/8<br>
6020 Innsbruck<br>
Austria - Österreich<br>
</div></div><br>______________________________<wbr>_________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/<wbr>mailman/listinfo/mkgmap-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div><div>Felix Hartman - Openmtbmap.org & VeloMap.org<br></div>Schusterbergweg 32/8<br></div><div>6020 Innsbruck<br></div></div>Austria - Österreich</div></div></div></div>
</div>