<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Is this patch still needed?<br>
<br>
I must say it didn't work at all anyhow so far. <br>
<br>
I think the problem is that for many ways I don't add oneway tag,
but still need the reversal to work as in 2013. Here is a list of
direction dependant tags - that also if no oneway present MUST make
sure that road is not reversed or old behaviour kept:<br>
<br>
incline<br>
bicycle:left<br>
bicycle:right<br>
oneway:bicycle<br>
bicycle:oneway<br>
cycleway:left<br>
cycleway:right<br>
<br>
(and maybe some others I right now don't recall).<br>
<br>
<br>
So far I haven't been able to render a correct map, with or without
patch. But I noticed that the patch doesn't apply clean anymore and
conflicts - so is there something for the better?<br>
Far too often the bicycle way has been on the wrong side of the
road, or arrows showing difficult to bike uphill (incline &
mtb:scale:uphill>1) way arrows showing wrong direction!<br>
<br>
<br>
(P.S. I'm basically still detached from fast internet and can only
start playing around from next Monday).<br>
<br>
<div class="moz-cite-prefix">On 20.04.2014 13:45, Gerd Petermann
wrote:<br>
</div>
<blockquote cite="mid:DUB112-W116DB8C327716B583AFBB249E5F0@phx.gbl"
type="cite">
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style>
<div dir="ltr">Hi WanMil,<br>
<br>
<div>> Ok, anyhow I will slowly start with some tests with
the tag reverser. I <br>
> think most of it will be static so it won't hurt if other
things are <br>
> refactored.<br>
Great. If you can implement it in HighwayHooks it should not
create <br>
problems.<br>
<br>
> <br>
> ><br>
> > Maybe you can look at it:<br>
> > I plan to evaluate all tags used in RoadMerger once<br>
> > in ConvertedWay and place them<br>
> > in fields (most of them are booleans).<br>
> > RoadMerger should then call ConvertedWay.isSimilar()<br>
> > which will implement most of the compare routines
now implemented<br>
> > in RoadMerger.Road.<br>
> > Does that sound okay for you?<br>
> <br>
> I don't see the big advantage now but I am sure you have
a good idea why <br>
> it helps :-)<br>
> One small comment: I have some doubts that it is a good
idea to put the <br>
> isSimilar() method to the ConvertedWay class. There is a
similar <br>
> approach in MapElement. But the implementation does not
really help. <br>
> Maybe there are also different views at different stages
of the <br>
> processing if two elements are similar or not. So better
leave the <br>
> isSimilar method at the RoadMerger who knows better if
the two elements <br>
> can be merged or not.<br>
<br>
Good point.<br>
My idea is that RoadMerger should use the ConvertedWay
instances<br>
instead of creating new Road instances, but most of the code
in RoadMerger<br>
is in the Road class. <br>
<br>
Gerd<br>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
mkgmap-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a>
<a class="moz-txt-link-freetext" href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a></pre>
</blockquote>
<br>
</body>
</html>