<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi WanMil,<br><br><div>> Ok, anyhow I will slowly start with some tests with the tag reverser. I <br>> think most of it will be static so it won't hurt if other things are <br>> refactored.<br>Great. If you can implement it in HighwayHooks it should not create <br>problems.<br><br>> <br>> ><br>> > Maybe you can look at it:<br>> > I plan to evaluate all tags used in RoadMerger once<br>> > in ConvertedWay and place them<br>> > in fields (most of them are booleans).<br>> > RoadMerger should then call ConvertedWay.isSimilar()<br>> > which will implement most of the compare routines now implemented<br>> > in RoadMerger.Road.<br>> > Does that sound okay for you?<br>> <br>> I don't see the big advantage now but I am sure you have a good idea why <br>> it helps :-)<br>> One small comment: I have some doubts that it is a good idea to put the <br>> isSimilar() method to the ConvertedWay class. There is a similar <br>> approach in MapElement. But the implementation does not really help. <br>> Maybe there are also different views at different stages of the <br>> processing if two elements are similar or not. So better leave the <br>> isSimilar method at the RoadMerger who knows better if the two elements <br>> can be merged or not.<br><br>Good point.<br>My idea is that RoadMerger should use the ConvertedWay instances<br>instead of creating new Road instances, but most of the code in RoadMerger<br>is in the Road class. <br><br>Gerd<br><br></div> </div></body>
</html>