<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi all,<br><br>I've changed the code again, and also changed the options docu:<br> * the original OSM way is only passed through the lines rules <br> * if the way is closed a copy is created, the natural=* tag<br> is replaced with mkgmap:removed_natural=* and this copy is only passed through <br> the polygon rules<br><br>@WanMil: <br>Please review also the changes in the docu files, I am not sure<br>about the formatting rules. <br><br>Gerd<br><br><div>> Date: Wed, 19 Feb 2014 21:57:26 +0100<br>> From: wmgcnfg@web.de<br>> To: mkgmap-dev@lists.mkgmap.org.uk<br>> Subject: Re: [mkgmap-dev] Distorted lines<br>> <br>> Hi Gerd,<br>> <br>> at the moment I have no Java environment so I can only comment on the <br>> patch without testing my changes.<br>> <br>> The tags of the original way need to be copied to the new coastlineWay. <br>> After that you have a typo so that you delete the natural tag from the <br>> original way instead of coastlineWay. It should look like (on both places):<br>> <br>> // add a copy of this way to be able to draw the coastline which is not <br>> possible with precompiled sea<br>> Way coastlineWay = new Way(FakeIdGenerator.makeFakeId(), way.getPoints());<br>> coastlineWay.copyTags(way);<br>> coastlineWay.deleteTag("natural");<br>> coastlineWay.addTag("mkgmap:removed_natural",natural);<br>> // tag that this way is used as polygon only<br>> coastlineWay.addTag(MultiPolygonRelation.STYLE_FILTER_TAG, <br>> MultiPolygonRelation.STYLE_FILTER_POLYGON);<br>> saver.addWay(coastlineWay); <br>> <br>> <br>> Some small nit-picking:<br>> All tags added by mkgmap should start with "mkgmap:". So the tag need to <br>> be named mkgmap:removed_natural=coastline or <br>> mkgmap:removed:natural=coastline or ??.<br>> <br>> WanMil<br>> <br>> <br>> > Hi WanMil,<br>> ><br>> > I just want to avoid the situation that Minko had in the first place:<br>> > A rule that checks for a tag that mkgmap has removed.<br>> > I think that if we do this, it is a good idea to allow the style to<br>> > ask for the removed info.<br>> > Attached is a patch that implements your proposal<br>> > and changes the natural=coastline tag to removed_natural=coastline.<br>> ><br>> > coastline-v2.patch<br>> > <http://gis.19327.n5.nabble.com/file/n5796845/coastline-v2.patch><br>> ><br>> > Gerd<br>> ><br>> ><br>> > WanMil wrote<br>> >> Hi Gerd,<br>> >><br>> >> mkgmap:natural=coastline?<br>> >><br>> >> For my example I don't see a good reason having that tag. Can you give<br>> >> one where you need this information?<br>> >><br>> >> WanMil<br>> >><br>> >>> Hi WanMil,<br>> >>><br>> >>> I see. Wouldn't it be better to add<br>> >>> also a tag so that the style can find out that<br>> >>> Seagenerator deleted the natural=coastline tag?<br>> >>> If yes, what would be a good tag for this?<br>> >>><br>> >>> Gerd<br>> >>><br>> >>> > Date: Wed, 19 Feb 2014 21:00:46 +0100<br>> >>> > From:<br>> ><br>> >> wmgcnfg@<br>> ><br>> >>> > To:<br>> ><br>> >> mkgmap-dev@.org<br>> ><br>> >>> > Subject: Re: [mkgmap-dev] Distorted lines<br>> >>> ><br>> >>> > Hi Gerd,<br>> >>> ><br>> >>> > I think this might cause problems.<br>> >>> ><br>> >>> > In case you want to use polygons tagged with place=island you will<br>> >>> lose<br>> >>> > all islands that are also tagged as natural=coastline. This tagging is<br>> >>> > described on the wiki page<br>> >>> > (http://wiki.openstreetmap.org/wiki/Tag:place%3Disland).<br>> >>> ><br>> >>> > I think the patch can be extended in such a way that the coastline way<br>> >>> > is copied. The copy need to be processed by the polygon rules only and<br>> >>> > the natural=coastline is removed. This should catch all cases?<br>> >>> ><br>> >>> > Sorry for having a look into the patch late!<br>> >>> ><br>> >>> > WanMil<br>> >>> ><br>> >>> ><br>> >>> > > Hi Minko,<br>> >>> > ><br>> >>> > > committed with r3064.<br>> >>> > ><br>> >>> > > Gerd<br>> >>> > ><br>> >>> > ><br>> >>> > > ligfietser wrote<br>> >>> > >> Gerd, can you commit your coastline patch in the branch version?<br>> >>> > >><br>> >>> > >> _______________________________________________<br>> >>> > >> mkgmap-dev mailing list<br>> >>> > ><br>> >>> > >> mkgmap-dev@.org<br>> >>> > ><br>> >>> > >> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> >>> > ><br>> >>> > ><br>> >>> > ><br>> >>> > ><br>> >>> > ><br>> >>> > > --<br>> >>> > > View this message in context:<br>> >>> http://gis.19327.n5.nabble.com/Distorted-lines-tp5775761p5796839.html<br>> >>> > > Sent from the Mkgmap Development mailing list archive at Nabble.com.<br>> >>> > > _______________________________________________<br>> >>> > > mkgmap-dev mailing list<br>> >>> > ><br>> ><br>> >> mkgmap-dev@.org<br>> ><br>> >>> > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> >>> > ><br>> >>> ><br>> >>> > _______________________________________________<br>> >>> > mkgmap-dev mailing list<br>> >>> ><br>> ><br>> >> mkgmap-dev@.org<br>> ><br>> >>> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> >>><br>> >>><br>> >>> _______________________________________________<br>> >>> mkgmap-dev mailing list<br>> >>><br>> ><br>> >> mkgmap-dev@.org<br>> ><br>> >>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> >>><br>> >><br>> >> _______________________________________________<br>> >> mkgmap-dev mailing list<br>> ><br>> >> mkgmap-dev@.org<br>> ><br>> >> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> ><br>> ><br>> ><br>> ><br>> ><br>> > --<br>> > View this message in context: http://gis.19327.n5.nabble.com/Distorted-lines-tp5775761p5796845.html<br>> > Sent from the Mkgmap Development mailing list archive at Nabble.com.<br>> > _______________________________________________<br>> > mkgmap-dev mailing list<br>> > mkgmap-dev@lists.mkgmap.org.uk<br>> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> ><br>> <br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br></div> </div></body>
</html>