<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi WanMil,<br><br>reg. turn restrictions I see no change in my test case, but I just compared the numbers.<br><br>Gerd<br><br><div>Date: Sat, 11 Jan 2014 22:25:55 +0100<br>From: wmgcnfg@web.de<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: Re: [mkgmap-dev] [PATCH] RoadMerger reverses roads<br><br><pre>Attached is another patch that reverses roads in the RoadMerger if <br>applicable.<br> <br>I have checked the patch by adding debug statements to the <br>RestrictionRelation.addRestriction(..) method. There are some <br>differences but as far as I could see the differences are only in some <br>coords. I have checked some and all were caused by road merges.<br> <br>Example:<br> <br>3---2---<br> \<br>4--------1---5<br>When having a only_straightforward restriction from 4 via 1 to 5 point 2 <br>is added to the restriction without merging. When merging the road 1-2 <br>and 2-3 node 2 is no longer a routing node and therefor point 3 is added <br>to the restriction instead of point 2.<br> <br>@Gerd: can you please check again if your tests still show any problem? <br>Thanks!<br> <br>WanMil<br> <br> <br>> Hi Gerd,<br>><br>> I've found two problems but have no time today to fix it. Will post a<br>> patch within the next days.<br>><br>> Thanks a lot for testing!!<br>><br>> WanMil<br>><br>>> Hi Gerd,<br>>><br>>> I will check that.<br>>><br>>> WanMil<br>>><br>>>> Hi WanMil,<br>>>><br>>>> the patch has an influence on the number of turn restrictions.<br>>>> For a tile in northern Germany GPSMapEdit shows :<br>>>> r2946 with --x-no-mergeroads: 264 (valid) turn restirictions, 22 invalid<br>>>> r2946 with activated mergeroads : 264 (valid) turn restirictions, 22<br>>>> invalid<br>>>> r2946 with patch and --x-no-mergeroads: 264 (valid) turn restirictions,<br>>>> 22 invalid<br>>>> r2946 with patch and activated mergeroads : *223* (valid) turn<br>>>> restirictions, *25 *invalid<br>>>><br>>>> (The invalid turn restrictions are listed in the log. Those are the ones<br>>>> that prohibit<br>>>> to drive into the wrong end of a oneway road, but GPSMapEdit doesn't<br>>>> care when<br>>>> the turn restriction also forbids to walk into the road)<br>>>><br>>>> Do you think that this could be okay?<br>>>><br>>>> Gerd<br>>>><br>>>> Date: Wed, 8 Jan 2014 22:55:43 +0100<br>>>> From: wmgcnfg@web.de<br>>>> To: mkgmap-dev@lists.mkgmap.org.uk<br>>>> Subject: [mkgmap-dev] [PATCH] RoadMerger reverses roads<br>>>><br>>>> Attached patch improves the RoadMerger so that roads are reversed when<br>>>> it is required to be merged with another road.<br>>>><br>>>> A small test increased the mergerate by 2% (avg. 17% => 19% road network<br>>>> reduction).<br>>>><br>>>> Please check it. The p-road check is not yet implemented.<br>>>> There are also some performance improvements possible which I will post<br>>>> with the next patch version.<br>>>> Unit tests may fail.<br>>>><br>>>> WanMil<br>>>><br>>>>> Hi Gerd,<br>>>>><br>>>>>> Hi WanMil,<br>>>>>><br>>>>>> two points:<br>>>>>> 1) line 517 is obsolete:<br>>>>>> mergePoints.add(end);<br>>>>>> It just blows up the size of the list and processing time.<br>>>>><br>>>>> Yep.<br>>>>> I've found another important thing: the road merger can merge many more<br>>>>> ways when it reverses non oneway ways. This should be no problem so<br>>>>> let's do it :-)<br>>>>> I will post another patch.<br>>>><br>>>><br>>>><br>>>> _______________________________________________ mkgmap-dev mailing list<br>>>> mkgmap-dev@lists.mkgmap.org.uk<br>>>> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>>>><br>>>><br>>>> _______________________________________________<br>>>> mkgmap-dev mailing list<br>>>> mkgmap-dev@lists.mkgmap.org.uk<br>>>> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>>>><br>>><br>>> _______________________________________________<br>>> mkgmap-dev mailing list<br>>> mkgmap-dev@lists.mkgmap.org.uk<br>>> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>><br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br> <br></pre><br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>