<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi WanMil,<br><br>it's a unit test regarding the style finalizer section which fails and I don't know why.<br><br>reg. RoadMerger:<br>it makes no sense to create closed ways because we would split them again later in StyledConverter.<br>I don't understand the idea about roundabouts.<br>If one is divided into 4 parts you can do 2 merges without closing it, no matter which <br>parts you connect first, and you should always get 2 remaining parts. Assumes part a,b,c and d:<br>a+b and c+d or <br>a+b and a_b + c or <br>b+c and d+a or <br>b+c and b_c + d or<br>b+c and a + b_c or <br>...<br><br>Gerd <br><br><div>> Date: Sun, 5 Jan 2014 12:37:09 +0100<br>> From: wmgcnfg@web.de<br>> To: mkgmap-dev@lists.mkgmap.org.uk<br>> Subject: Re: [mkgmap-dev] Unit tests in trunk fail<br>> <br>> Hi Gerd,<br>> <br>> I think I found the problem:<br>> <br>> // check if merging would create a closed way - which should not<br>> // be done (why? WanMil)<br>> if (cStart == cOtherEnd) {<br>> return false;<br>> }<br>> <br>> The RoadMerger avoids to create closed roads. In case the roads are not <br>> merged in exactly the same order this is the reason for different merge <br>> results due to roundabouts. In case a roundabout is divided in multiple <br>> ways the number of merged ways is random.<br>> <br>> At the moment I have no time to check that more in detail but I think <br>> the code listed above can be removed.<br>> <br>> WanMil<br>> <br>> > Hi WanMil,<br>> ><br>> > please have a look, I don't fully understand why.<br>> ><br>> > Gerd<br>> ><br>> ><br>> > _______________________________________________<br>> > mkgmap-dev mailing list<br>> > mkgmap-dev@lists.mkgmap.org.uk<br>> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br>> ><br>> <br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br></div> </div></body>
</html>