logo separator

[mkgmap-dev] methods to write signed / unsigned integers

From Ticker Berkin ticker at jagIT.co.uk on Thu Mar 15 14:21:25 GMT 2018

Hi Gerd

I've attached the Display patch - this was a quick hack global edit and
could be improved by using the relevant signed/unsigned get methods
instead of masking...  I'm happy to do this - let me know.

Yes to DEM changes. Also the nearby asserts can go now because put2s()
will check the range.

  // don't think needed:
could be changed to
  // not needed at moment:
but I think it is worth leaving these methods (getNs()/putNs())
commented in the ImgFile interface source.


On Thu, 2018-03-15 at 10:12 +0000, Gerd Petermann wrote:
> Hi Ticker,
> sorry, did not find the time to look at it until now.
> At least for DEM this would not be correct, some values should be
> written with the signed put versions.
> I've attached a corrected version of the patch.
> Besides that I'd prefer not to see comments like
> // don't think needed:
> For further testing I'd need the patch for display tool as well.
> Gerd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: display_io_1.patch
Type: text/x-patch
Size: 36081 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20180315/671a1671/attachment-0001.bin>

More information about the mkgmap-dev mailing list