logo separator

[mkgmap-dev] error in NumberPreparer?

From Steve Ratcliffe steve at parabola.me.uk on Tue Apr 21 10:24:47 BST 2015

Hi Gerd

> it seems that NumberPreparer (in trunk) doesn't completely ignore
> the start/end values when numberStyle == NONE.

I was just going to post that the patch failed with NumberRangeTest,
wheras trunk passes.  It seems you may have found the answer but I
don't think this code should be reached when both styles are NONE
since it should have exited at numbers.isEmpty() -- at least in the
original code.

> See line 116:
>          if (first.getLeftStart() > first.getLeftEnd() ||
> first.getRightStart() > first.getRightEnd())
>              initial = Math.max(initial, rightStart);
>          else if (rightStart > 0)
>              initial = Math.min(initial, rightStart);

I've got to go out now, I will try to have a look at it later.

..Steve


More information about the mkgmap-dev mailing list