[mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

Tue Feb 3 07:06:22 GMT 2015

Hi Steve,

reg. the failed test:
I think you can change the test because StyledConverter doesn't do
this (at least not now). 
If you think it should be working we would need a method to
reset the field "current" in all LinkedOps so that they are evaluated again
for the same Element instance.

Gerd 

Date: Mon, 2 Feb 2015 23:26:09 +0000
From: steve at parabola.me.uk
To: mkgmap-dev at lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

Hi

I found a place in the code which only dealt with a single OR.  Changing
that to deal with any number seems to fix the problem.

There is however a problem that a test fails.  It does not appear to
be directly related to the fix, since it only occurs when resolving
the same way with different (changed) tags against the same
rule set.  That needs more investigation.

Patch attached, and jar here: 
http://files.mkgmap.org.uk/download/247/mkgmap.jar

> as A drian pointed out here:
>
> http://gis.19327.n5.nabble.com/Bug-in-handling-of-bus-stops-tp5832099.html
>
> we have a bug in the style evaluation system. The attached patch
> makes sure that each rule is only evaluated once for one element.
> If I got it right the problem occurs with rules that combine two
> "or" expressions, like
> (a | b) & ( c |  d) { do something }
>
> A binary based on r3436 is here:
> |http://files.mkgmap.org.uk/download/244/mkgmap.jar
> |
> @Steve: Please review, I've added a new field "matched" to
> WatchableTypeResult
> but I think the field "found" was  already intended for this?
> Maybe you find a better place to fix this?
>
> Gerd
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150203/e3f23079/attachment.html>