[mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

Mon Feb 2 08:23:52 GMT 2015

Hi all,

as A drian pointed out here:

http://gis.19327.n5.nabble.com/Bug-in-handling-of-bus-stops-tp5832099.html

we have a bug in the style evaluation system. The attached patch 
makes sure that each rule is only evaluated once for one element.
If I got it right the problem occurs with rules that combine two 
"or" expressions, like 
(a | b) & ( c |  d) { do something }

A binary based on r3436 is here:

http://files.mkgmap.org.uk/download/244/mkgmap.jar

@Steve: Please review, I've added a new field "matched" to WatchableTypeResult
but I think the field "found" was  already intended for this?
Maybe you find a better place to fix this?

Gerd

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150202/90467e22/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-dup-rule-evaluation-v1.patch
Type: application/octet-stream
Size: 11563 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150202/90467e22/attachment.obj>