[mkgmap-dev] [Patch v1] check length in substring style function

Tue Dec 16 10:31:42 GMT 2014

Hi Steve,

right. I just added a few tests. Feel free to change the patch and
commit it now.

Gerd

Date: Tue, 16 Dec 2014 09:22:05 +0000
From: steve at parabola.me.uk
To: mkgmap-dev at lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] [Patch v1] check length in substring style function

Hi Gerd

> I forgot to answer this post from gbbickerton:
> "May i suggest  that a test is made to check that the string is long
> enough before applying this filter otherwise an exception occurs .It
> would be unsafe to use this filter in any style without such a test. "

Well remembered, thanks.

It could also do with some tests, I've attached some.

I would like to use SyntaxException instead of ExitException for
all cases where an error can be detected at compile time
in a style file.

I realise that ExitException was already used in that class.
PartFilter is the only other example I can see where it does
not use SyntaxException.

..Steve

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141216/233db524/attachment.html>