[mkgmap-dev] Assertion error with r3350

Sun Nov 23 09:35:18 GMT 2014

Hi Steve,

I looked at this again. I think the comment disturbed me because
there is also an example "4a" and I first wondered if there is really 
a special treatment for this, and the old (wrong) code did not show
so clearly what was really meant.
I've attached a small patch to improve the comments.

Gerd

> Date: Fri, 21 Nov 2014 09:58:13 +0000
> From: steve at parabola.me.uk
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] Assertion error with r3350
> 
> Hi Gerd
> 
> > for SimpleStreetPhoneNumber are a bit confusing.
> > I don't understand the (or A) in  "If the string is not all numeric (or A) "
> 
> The code converts from base 11 to a string using a general routine so
> that it uses 0123456789A in the same way that hexadecimal uses
> 0123456789ABCDEF.
> 
> Since that routine is not used elsewhere, we could make it specific
> to base 11 and replace String digit = 
> "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
> with "0123456789-"
> 
> ..Steve
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141123/44a4fa32/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: poi-comments-v1.patch
Type: application/octet-stream
Size: 932 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141123/44a4fa32/attachment.obj>