[mkgmap-dev] highway count not fixed yet... - merge-roads-branch

Thu Sep 26 20:57:47 BST 2013

Hi WanMil,

at least we should know if options like frig-roundabout are used. Afaik the default style will never touch these
routines. I guess Felix uses almost all.

Gerd

> Date: Thu, 26 Sep 2013 21:53:20 +0200
> From: wmgcnfg at web.de
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] highway count not fixed yet... - merge-roads-branch
> 
> Yeah, I guess it should be possible to simplify them be 
> reimplementation. But that's only a rough guess....
> 
> A test case would be great to find the missing incHighwayCount()!
> 
> > Hi WanMil,
> >
> > yes, first and last node should be coordNode, so the assert is ok.
> > Unfortunately, the data flow in StyledConverter is
> > so complex that it is difficult to say why the assertion is triggered. I
> > guess one of the split routines is still
> > missing a call of incHighwayCount().
> >
> > Gerd
> >
> >
> >  > Date: Thu, 26 Sep 2013 21:42:28 +0200
> >  > From: wmgcnfg at web.de
> >  > To: mkgmap-dev at lists.mkgmap.org.uk
> >  > Subject: Re: [mkgmap-dev] highway count not fixed yet... -
> > merge-roads-branch
> >  >
> >  > Yes, it is meant to reduce the number of CoordNodes because that should
> >  > reduce the size of the routing network and might have a positive impact.
> >  >
> >  > The assertion reported by Felix seems to be a problem of the highway
> >  > count. The assertion checks if the first node of a MapRoad is a
> >  > CoordNode. I think this is required, isn't is?
> >  > While writing I am thinking of no exit roads. What about these roads? I
> >  > think the first and the last point should also be a CoordNode?!?
> >  >
> >  > WanMil
> >  >
> >  > > Hi WanMil,
> >  > >
> >  > > yes, it will not cause problems. On the other hand, if you do it to
> >  > > reduce the number of CoordNodes, we should try to have a correct
> >  > > counter. I think the short-arc-removal is not always correctly
> >  > > maintaining it. I'll have a look at it tomorrow.
> >  > >
> >  > > Gerd
> >  > >
> >  > >
> >  > >
> >  > >
> >  > > WanMil wrote
> >  > >> Hi Gerd,
> >  > >>
> >  > >> decHighwayCount() is called only on the node where two roads are
> > merged.
> >  > >> So assuming that the highway count gives the number of connected roads
> >  > >> calling this method in such a case should be ok.
> >  > >>
> >  > >> WanMil
> >  > >>
> >  > >>> Hi WanMil,
> >  > >>>
> >  > >>> reg. the highway count:
> >  > >>> I guess you already noticed, but just to make sure:
> >  > >>> In trunk the absolute value of the counter does not really matter
> >  > >>> as long as it is > 1 for each point that should be converted to a
> >  > >>> node. I think a lot of routines are calling
> >  > >>> incHighwayCount() "just to make sure", so a node where two
> >  > >>> arcs meet might have a counter > 2.
> >  > >>> You have introduced decHighwayCount(), so now
> >  > >>> each place where this counter is incremented has
> >  > >>> to be double checked.
> >  > >>>
> >  > >>> Gerd
> >  > >>>
> >  > >>>
> >  > >>> WanMil wrote
> >  > >>>> Ok, but I need some food (style, data etc.) to reproduce it...
> >  > >>>>
> >  > >>>>> Just cannot find the topic on the merge-roads-branch.
> >  > >>>>>
> >  > >>>>> Is it known that the highway count error is not fully fixed yet? I
> >  > >>>>> still
> >  > >>>>> get loads of them.
> >  > >>>>> _______________________________________________
> >  > >>>>> mkgmap-dev mailing list
> >  > >>>>>
> >  > >>>
> >  > >>>> mkgmap-dev at .org
> >  > >>>
> >  > >>>>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >  > >>>>>
> >  > >>>>
> >  > >>>> _______________________________________________
> >  > >>>> mkgmap-dev mailing list
> >  > >>>
> >  > >>>> mkgmap-dev at .org
> >  > >>>
> >  > >>>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >  > >>>
> >  > >>>
> >  > >>>
> >  > >>>
> >  > >>>
> >  > >>> --
> >  > >>> View this message in context:
> >  > >>>
> > http://gis.19327.n5.nabble.com/highway-count-not-fixed-yet-merge-roads-branch-tp5778802p5779025.html
> >  > >>> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> >  > >>> _______________________________________________
> >  > >>> mkgmap-dev mailing list
> >  > >>>
> >  > >
> >  > >> mkgmap-dev at .org
> >  > >
> >  > >>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >  > >>>
> >  > >>
> >  > >> _______________________________________________
> >  > >> mkgmap-dev mailing list
> >  > >
> >  > >> mkgmap-dev at .org
> >  > >
> >  > >> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >  > >
> >  > >
> >  > >
> >  > >
> >  > >
> >  > > --
> >  > > View this message in context:
> > http://gis.19327.n5.nabble.com/highway-count-not-fixed-yet-merge-roads-branch-tp5778802p5779102.html
> >  > > Sent from the Mkgmap Development mailing list archive at Nabble.com.
> >  > > _______________________________________________
> >  > > mkgmap-dev mailing list
> >  > > mkgmap-dev at lists.mkgmap.org.uk
> >  > > http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >  > >
> >  >
> >  > _______________________________________________
> >  > mkgmap-dev mailing list
> >  > mkgmap-dev at lists.mkgmap.org.uk
> >  > http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> >
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20130926/2e99deac/attachment-0001.html 