[mkgmap-dev] [PATCH v1] Rework of the location-autofill parameter

Thu Sep 20 11:24:23 BST 2012

Hi,

Coming back to the blank cities issue with Edge 705: the problem was
never fixed because it was not a mkgmap problem per se, but more a map
problem. This happened when using --add-pois-to-area. The problem is
with the OSM map: some places have both a “city/village” unnamed
polygon plus a poi for the village with the name. Using
--add-pois-to-area leads to creating both POIs, one of them being
blank. This could be fixed with several solutions:
1)	Map should be corrected (remove POI node village and name the
polygon). This is fastidious but would be the best one. However this
is not practicable if you need to generate the map of a country.
2)	Do not use --add-pois-to-areas (but you will miss POIs in areas)
3)	Use “--add-pois-to-areas --name-tag-list=name,place_name” (this
will fill the name of the POI to the unnamed polygon but in the cities
list you’ll get place duplicates)
4)	Use “--add-pois-to-areas", but NOT
"--name-tag-list=name,place_name” and use a style which will fix the
issue: in the points file by adding “ & name=*” to each “place=XXX”
entry. Perfect solution.

Regarding the new mkgmap code, these are the test results:

0) First, I generated the bounds file myself, using:

$ java -jar mkgmap-r2328/mkgmap.jar --bounds=bounds
--createboundsfile=great_britain-boundaries.osm.pbf

The file great_britain-boundaries.osm.pbf was itself generated with
osmosis from the great_britain.osm.pbf file from Geofabrik.

Then I created the gmapsupp files in 3 ways, and tested for the
presence of blank lines on my Edge 705:

1) Do NOT use --add-pois-to-area, default style

$ java -Xmx3000M -jar mkgmap-r2336/mkgmap.jar --route
--remove-short-arcs --latin1 --bounds=bounds
--location-autofill=is_in,nearest --adjust-turn-headings
--link-pois-to-ways --ignore-turn-restrictions --ignore-maxspeeds
--check-roundabouts --make-all-cycleways --index --gmapsupp
--report-undefined-nodes -c template.args

--> no blank lines

2) Use --add-pois-to-area, default style

$ java -Xmx3000M -jar mkgmap-r2336/mkgmap.jar --route
--remove-short-arcs --latin1 --bounds=bounds
--location-autofill=is_in,nearest --adjust-turn-headings
--link-pois-to-ways --ignore-turn-restrictions --ignore-maxspeeds
--check-roundabouts --make-all-cycleways --add-pois-to-areas --index
--gmapsupp --report-undefined-nodes -c template.args

--> blank lines, freeze when searching nearest cities

3) Use --add-pois-to-area, CFMaster style from
http://www.cferrero.net/maps/downloads/CF_GPS.zip where “ & name=*”
appended to each “place=XXX” entry in the points file.

$ java -Xmx3000M -jar mkgmap-r2336/mkgmap.jar --route
--remove-short-arcs --latin1 --bounds=bounds
--location-autofill=is_in,nearest --adjust-turn-headings
--link-pois-to-ways --ignore-turn-restrictions --ignore-maxspeeds
--check-roundabouts --make-all-cycleways --add-pois-to-areas --index
--gmapsupp --style-file=style_CF --family-id=1500
--report-undefined-nodes -c template.args CFMaster_FID_1500.TYP

--> no blank lines (thanks to the "& name=*" added in the points file)

So it seems that the new code does not introduce blank cities (at
least where I live). But with --add-pois-to-area, the problem and its
solutions are exactly the same than before.

Thus, may I suggest we change the default style file (by adding the "&
name=*" entry as described above) if this does not lead to other
issues (works for me)?

Eric